<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/58958>58958</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            Error message about pointer conversion instructs me to write a bug
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          notnullnotvoid
      </td>
    </tr>
</table>

<pre>
    

When passing a variable of type `const char *` to a function accepting `void *`, I get an error message like the following:
```
bob.cpp:184:25: error: no matching function for call to 'MeowHash'
    meow_u128 hash128 = MeowHash(MeowDefaultSeed, strlen(path), path);
                        ^~~~~~~~
./meow_hash_x64_aesni.h:259:1: note: candidate function not viable: no known conversion from 'const char *' to 'void *' for 3rd argument; take the address of the argument with &
```
Presumably because of const-ness. This error message is correct, except for this instruction at the end: `take the address of the argument with &`. In this case the correct thing to is to explicitly cast to `void *`, and if I assumed the compiler knew what it was talking about and followed its instructions, I would write a potentially easy-to-miss pointer bug.

You could argue a programmer should have the dilligence to double-check and not trust the compiler in a case like this, and in principle I agree, but the type of inexperienced programmer who is most likely to find these hints helpful, and most likely to follow them, is also the type most likely to miss a bug like this, so I think this is likely to do harm in practice.

As far as I know there's no way for the compiler to tell what the correct solution in this case is, so the message should probably either not be printed in a case like this with incompatible pointer types, or rephrased to make it clear this is only a suggestion of what *might* be the solution.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyNVk1v6zYQ_DXyhbBgS9aHDz7kNS9oDgUKtEDRU0CRK4kNJQokZSf_vkNKTuw0hwqCJJPc3dmZXdKNke-nJNsnxQ818I6S4jHJ6t77ySX5Q5I94Z4d2W2cdWmnfD83YUSY0dPoU2EGrMmrrCp3RYnPbLc_HOtDlW2bUlZ0EGJ7zOVhe2grvq3LXG7bTOY7TJQ1p3QauyQ7JrvHZPewPP_qaWQTd06NHePszK3ijSZmWubfJ2JJuUNw55nouWVJ9oAB5g2WtvMovDIj40LQ5IM95s5GyXVZkv3CnllHnvGRkbXGsoGcQ2pMq1divifWGq3NBbaBgAUWDJc7_mxMk4ppwvS-PuCZFXgs3sLHaNjAvehD9A9ALSIJrnXAmWTVb2Quv3LX43PxyXANGHyZ91nNekyFd5I_ss-ldfh8pJbP2v9BJEMyzltNI-Ym7vvAI8aun_mPT9_fXUnxM6m-u6NVCikjogDm5a08vHByo0r7mPExZL9k6ym8BR-lktzTZ86YYuco3UrL62guI4N2Z7IusmLNEOj4ImdWrTR9KIeRwGBuJeO2mwcUHtJjnq-acSktdIwlEn6ua9gF5QoH5bc6_g6TeQC-d9aQ4CjqYB-xbEd4S9mfvXJfygQDwlhLwgeq6S3UWcTmw1oFWzuvNegjFhplSB9R_z_acpey53FxKbhbrNawYRSVBYIwiSe9TVoJ5ZEFlvrI3H9qHuIw1aL00VWIJVeHw6Q0WehCF3bpAVgBBIdbrl9j8zVm9tF4aQoYKn-XpVs66mJmLdnFKujP2WTCzqBQ7u-MuHvferMdFBKejMKmYVkzd-ltx_9tZqAJLgIX0YU1neXDgMWujzM9Py88SKW16mgUFHKVZkaBbUVP4jUiDVUHdM7f56ggyMLl2ujKfRCD3caqUagJmwwo6ixRmGvmxUfcdKCVGsE1WRVCy1uElz6KMRgEDd6RNpC1aow8IyQUA2096amd9TXs1-WR4WAwhBXwx7UznwC-LI988sDkfUIweY4l8rpWpLsxkgY02mHJmENAQXc6PDjWogdRAc-xWUN0Cy4qF9r3wt_XSr_hFV49YV-L5XNbps7oOfaBui3kD5Bh6bWnVoXBaBO7kVSIG5VsKGrjSX6n4NIxkA5ouFfhkLiWWOAsxgJgS1NvYSgjcaELUedCE7cfHJkRcTlzc4dTLsKG4DEnNNGguh7t_hDQBNzX1NINnfZlWWfHMt_VG3nK5TE_8o1HN9Lp592-sbTSFd3NHnhtJtRPLOhrE0HZzWz16f4sXs7f9dDV-nx9bUHeP3FTekJhzCH1p6I-FvWmP-VVLQ-Z4DtZFFTLXdnUIiv2LY7g_NiIaqN5Q9qd8B8Ax_9GnbJdlu33-yzL8zqr05rvm7aggqqybXlbJ4cdDVzpNAROje029hQxALLDpFbOu8_JcJB3I9HVP599b-wJ6o6z1niFvWoTUZ8i5H8BcCTc5Q">