<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/58360>58360</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [lldb] Setting breakpoint by basename doesn't resolve if function name is a CPlusPlusParser keyword
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            lldb
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          Michael137
      </td>
    </tr>
</table>

<pre>
    Example program:
```
$ cat keyword.cpp 
template<typename U>
struct Foo {
    template<typename T>
    void import() {}
};

int main() {
    Foo<double> f;
    f.import<int>();
}

$ ./bin/lldb a.out
(lldb) target create "a.out"
Current executable set to 'a.out' (arm64).
(lldb) br se -n import
Breakpoint 1: no locations (pending).
WARNING:  Unable to resolve breakpoint to any actual locations.
(lldb) br se -r import
Breakpoint 2: 43 locations.
(lldb) 
```
This is on a Mac with lldb built from top-of-tree (as of `4ba360d499f6169d62a9535438b3cf34337ffc67`).

This regressed with `f968bd77bbcf142afdb74750e53485b044de3e5f`, where we made the symbol lookup for `eFunctionNameTypeFull` stricter. The patch itself seems fine, it simply exposed a bug in breakpoint resolution
with reserved keywords.

**Details**

The `import` identifier is a reserved keyword in the eyes of the `CPlusPlusLanguage`/`CPlusPlusNameParser` plugin. This means that the `eFunctionNameTypeAuto` (used when creating a breakpoint) gets turned into a `eFunctionNameTypeFull`, which after the commit mentioned above requires that the mangled name matches the symbol search name (in `DWARFIndex::ProcessFunctionDIE`). The relevant code block that resolves the name_type_mask is the following:

```
Module::LookupInfo::LookupInfo(ConstString name,               
                               FunctionNameType name_type_mask,
                               LanguageType language)
…
CPlusPlusLanguage::MethodName cpp_method(name);                           
basename = cpp_method.GetBasename();                                      
if (basename.empty()) {                                                   
  if (CPlusPlusLanguage::ExtractContextAndIdentifier(name_cstr, context,  
                                                     basename))           
    m_name_type_mask |= (eFunctionNameTypeMethod | eFunctionNameTypeBase);
  else                                                                    
    m_name_type_mask |= eFunctionNameTypeFull;  <<<< ExtractContextAndIdentifier fails to parse “import” because it’s a keyword         
```

Then the breakpoint resolver calls into `DWARFIndex::ProcessFunctionDIE` to find symbols matching the basename the user specified. But since the name_type_mask is `eFunctionNameTypeFull` we try to compare the mangled name against the non-mangled identifier, which call the DIE callback (whereas previously it would have):
```
bool DWARFIndex::ProcessFunctionDIE(
...
// In case of a full match, we just insert everything we find.             
if (name_type_mask & eFunctionNameTypeFull && die.GetMangledName() == name)
  return callback(die);  <<< Will now never be called
...                 
```

The real bug here is simply that the type_mask should be set to `eFunctionNameTypeMethod | eFunctionNameTypeBase` when constructing `Module::LookupInfo::LookupInfo`.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJytV8tym0oQ_Rq0mTIl8xQLLfxSylVxKnWTVJauARqJGBjdYbCtv7-nZxCyLdnx4lL4ATPTffr0k1yVu-XNs2y3DYmtVmstWy-88ObX3vzCS-bj7R6DSBTSiAfaPSld-sV2K9yKIZyXhrzwyuy21MmWxC8vvHGrvdFDYcRKKeGll-6dwHXq1M_pFO94VHUp6nartPGChRdkVkB6PeLBP-Eoz_2uOyNaWXcvNk-yoB6KSjXkDTTeiGo6y6uVP6oJryCEQVgRB_mT0okK3wtWOetaNU2ZC-mrwexXF_yKIRip12REoQmGCi8I3LYgcDuvBq0JoOmZisFIQBM9thswFaTj1hT_L6RukwgC_SMNucYRcdbtebLrl9D3sFXMxzncKTolGgXf1arrWRzYLutufRD4--Kfb7ffvvBe8auzQABCU6-aR4KOSRzeym4nZGEG2RyEvotLv4crYF1R-JGIk1H4c1P3ArfqhBR3shBPtdkI64J8qBsjKq1awNyeqerMaCJLH_ZXAjKiXIbJvIyyrErOk6xMApnFYRyFizwsqjAKw7SqiiRldQe2D4o1rUFKT6VTi21VlizyMk3zvKjOo0BWZZ5GaTynOIwWcT6PopJCiisr8Uo8bUiTeCLEaQmON3D4rs0VU6kehq2olGaptBq6gmn5hqz4iexYDU2D9wLJVBeGtC9-4uxWmmIjatNTU4FuantR1R2xotqIHtQ3OwTXVjFiCYLWou5eutN6eGBFzkhrFV6SfsSJMdN7_3Xs831NRtZN7x5e00RswOh1IK5LRHhd1aTZbfJIOiNiHmhH1kvGCbj63gw9_3yV3XqQa7IErl6uMDffpYY41rNthnXdMS9Q05JEpJsNytUo74jRi8EoPofwGKxDN9S5REVmMFkTSxyLyGLIG3RHDJiz4CM3OU_X8I2s4CyLoVBtC6e0zIZiMTJXyC1N_w41ODmAbWFwg3VbEFv2sF2dIqUnqSHZLgM86IPGa2Tw6rYr6ZnLd3jxXasCgbrHd317M4a0jRtNDT1K-L9QiMIcOfjg9I8Z7_Sxhnsuzfet7B_Ye_y2Uk2jnrh6hK8c_yZP71Q5cKVlMF9tbN92lTp6DhZXyH3zA2EN1lkjc_f6OpTpD663nniDHlI_JWYfbVZEsw89dAJn403gLebeRTKW76MYtebdkdmokoEI9Mj71j7CUmcdN5UPADjJuexdQ_TC6xdC_C9kLselqUP9xaJXcuuKQ2Yv3UcHNrtRkGuYnxN2QrIQTvY7nNw8G42mAWcbejYXXXk7lYWRmfsCtY2dX7g9Ng4-5bPTVz7xZG07xitEe_8mxL30igkHoqPMdk7lHeJojV3ycloQgho0v__h-jvW0yWIowKzzHSLD_gXFVdy7uxbLqZiDPLsaqzh4-O1yKmQKJVoLft3GRf0fR1_jfnt8LhvDq7Yv21Bj4BRyAYwbHH9bEFj0Gh45Vgae1cuuZJYJfsk4gcAx0SypYJtLn1xOXCD7Ap6p9R91ITRvo3esXIUdZBGx3VbrjGH9q6gd6o72y_WL8J-3yPYcLsRRtmHXKIeIwjtsIDZZavpsVZDj2aODvKkhqYUG_noYu50-c0VOsUnOETu2_2-P81fK9ziFr0Q9HFDlqKC3Y5aC5rEnwGmwT7SmF3hu52xpGOFveGfCGFXHN6GcJCcjl9e4cWyJi55d468b1PV47LIwb_P7zFLNHGHnijEXgjYF8lDLvyuoaFTT6Jj7Ahre4LKiYl30vC9kIZezMI8XNnhDsEzTl5TSz-Y3G-s9_LDoH8izv5aazgG7bjCvZO_rph9vP1k003m_oyW50kSp3G2yNJZuQzLLMzkzNSmoaUXX9oZPL4WP8hY4S8SNt8dMqtU1OMTKJ3SmLtANUJ2mWCHvqkruHltXzNmg26WG2O2PWO0kbfGBDrkPhLLflk97v-c4ev0DxVoC6u67wfC6LmKFxjmZ5tlnKQES_IqCSiJKMvTPIuTslykcZQURT5rZI6KzHbh08t9XgSwblYvg3kQnM_Po_N4HsWpnwRpmiVFnGVpWuSZ9KI54Yuy8RmCr_R6ppcWDbzdY7Gpe9MfFmXf1-uOLIMsXw5wpF7eIcslNedhOrPYlxb4f-5tuoc">