<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/58220>58220</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
[clang-tidy] macOS: false positives with CoreFoundation types, e.g. cppcoreguidelines-init-variables, etc.
</td>
</tr>
<tr>
<th>Labels</th>
<td>
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
H-G-Hristov
</td>
</tr>
</table>
<pre>
False positives:
- cppcoreguidelines-init-variables - on initialised variables
- readability-convert-member-functions-to-static - on methods which access member fields
- misc-unused-parameters
etc.
I use VSCode's cpptools extension which outputs a slightly different resault:
[Archive.zip](https://github.com/llvm/llvm-project/files/9732031/Archive.zip)
CLI output
> hhhhh@Hristos-MacBook-Pro mylib % clang-tidy -config-file=.clang-tidy '/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp'
Error while trying to load a compilation database:
Could not auto-detect compilation database for file "/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp"
No compilation database found in /Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos or any parent directory
fixed-compilation-database: Error while opening fixed database: No such file or directory
json-compilation-database: Error while opening JSON database: No such file or directory
Running without flags.
54775 warnings and 1 error generated.
Error while processing /Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp.
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:29:21: warning: constructor does not initialize these fields: plistRef [cppcoreguidelines-pro-type-member-init,hicpp-member-init]
class LaunchdPlist::LaunchdPlistImpl
^
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:83:9: warning: parameter 'dictionary' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
const CFDictionaryRef dictionary,
^~~~~~
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:134:1: warning: constructor does not initialize these fields: plistRef [cppcoreguidelines-pro-type-member-init,hicpp-member-init]
LaunchdPlist::LaunchdPlistImpl::LaunchdPlistImpl(const std::string_view content)
^
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:138:38: warning: method 'LoadFromString' can be made static [readability-convert-member-functions-to-static]
void LaunchdPlist::LaunchdPlistImpl::LoadFromString(std::string_view plistStr)
^
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:138:70: warning: parameter 'plistStr' is unused [misc-unused-parameters]
void LaunchdPlist::LaunchdPlistImpl::LoadFromString(std::string_view plistStr)
^~~~~~~~
/*plistStr*/
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:153:38: warning: method 'LoadFromFile' can be made static [readability-convert-member-functions-to-static]
void LaunchdPlist::LaunchdPlistImpl::LoadFromFile(std::string_view filepath)
^
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:153:68: warning: parameter 'filepath' is unused [misc-unused-parameters]
void LaunchdPlist::LaunchdPlistImpl::LoadFromFile(std::string_view filepath)
^~~~~~~~
/*filepath*/
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:196:5: warning: 2 adjacent parameters of 'GetObjectsFromArrayOfDictionariesFor' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters]
std::string_view keyName, const std::function<T(CFDictionaryRef dictionary)>& MakeObject)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:196:22: note: the first parameter in the range is 'keyName'
std::string_view keyName, const std::function<T(CFDictionaryRef dictionary)>& MakeObject)
^~~~~~~
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:196:83: note: the last parameter in the range is 'MakeObject'
std::string_view keyName, const std::function<T(CFDictionaryRef dictionary)>& MakeObject)
^~~~~~~~~~
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:196:5: note: after resolving type aliases, the common type of 'std::string_view' and 'const int &' is 'int'
std::string_view keyName, const std::function<T(CFDictionaryRef dictionary)>& MakeObject)
^
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:196:31: note: 'std::string_view' and 'const int &' parameters accept and bind the same kind of values
std::string_view keyName, const std::function<T(CFDictionaryRef dictionary)>& MakeObject)
^
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:208:49: warning: variable 'itemsRef' is not initialized [cppcoreguidelines-init-variables]
const ::nblib::types::CFWeakRef<CFArrayRef> itemsRef{CFDictionaryGetValue(plistRef.Get(), keyNameRef.Get())};
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:214:20: warning: variable 'resultItems' is not initialized [cppcoreguidelines-init-variables]
std::vector<T> resultItems;
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:216:19: warning: variable 'itemCount' is not initialized [cppcoreguidelines-init-variables]
const CFIndex itemCount = CFArrayGetCount(itemsRef.Get());
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:217:18: warning: variable 'i' is not initialized [cppcoreguidelines-init-variables]
for (CFIndex i = 0; i < itemCount; i++) {
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:218:58: warning: variable 'item' is not initialized [cppcoreguidelines-init-variables]
const ::nblib::types::CFWeakRef<CFDictionaryRef> item{CFArrayGetValueAtIndex(itemsRef.Get(), i)};
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:241:50: warning: variable 'valueRef' is not initialized [cppcoreguidelines-init-variables]
const ::nblib::types::CFWeakRef<CFNumberRef> valueRef{CFDictionaryGetValue(plistRef.Get(), keyNameRef.Get())};
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:262:49: warning: variable 'itemsRef' is not initialized [cppcoreguidelines-init-variables]
const ::nblib::types::CFWeakRef<CFArrayRef> itemsRef{CFDictionaryGetValue(plistRef.Get(), keyNameRef.Get())};
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:268:19: warning: variable 'itemCount' is not initialized [cppcoreguidelines-init-variables]
const CFIndex itemCount = CFArrayGetCount(itemsRef.Get());
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:269:30: warning: variable 'resultItems' is not initialized [cppcoreguidelines-init-variables]
std::vector<std::string> resultItems;
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:271:18: warning: variable 'i' is not initialized [cppcoreguidelines-init-variables]
for (CFIndex i = 0; i < itemCount; i++) {
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:272:54: warning: variable 'item' is not initialized [cppcoreguidelines-init-variables]
const ::nblib::types::CFWeakRef<CFStringRef> item{CFArrayGetValueAtIndex(itemsRef.Get(), i)};
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:295:50: warning: variable 'valueRef' is not initialized [cppcoreguidelines-init-variables]
const ::nblib::types::CFWeakRef<CFStringRef> valueRef{CFDictionaryGetValue(plistRef.Get(), keyNameRef.Get())};
^
= 0
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.cpp:306:38: warning: variable 'AppendSubkeyValueIfExists' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
void LaunchdPlist::LaunchdPlistImpl::AppendSubkeyValueIfExists(
^
/Users/hhhhh/Projects/GitHub/mylib/src/utilities/src/macos/LaunchdPlist.hpp:5:10: error: 'tl/optional.hpp' file not found [clang-diagnostic-error]
#include <tl/optional.hpp>
^~~~~~~~~~~~~~~~~
Suppressed 54752 warnings (54752 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJztW1GT2jgS_jWeF5UpW7YxPPAwwwzJXGWT1M7d3uOWbMugjLF8lsyE_fXXLRkwhGGYhCFsbSjK2LLcan39dasli0Rmy9GEFYqTSiqhxYIrJ7h2vFvHa48uSasqlTWfNiLjhSi5ckUptLtgtWBJwRVxiSwJlglWCMUzsr61ElFzlrFEFEIv3VSWC15rd87nCa_dvClTLWSpXC1dpZkWqRU453omM0WeZiKdEZamXCliHyK54EW2lj4XKnWbsoGm3YrVDJ7ktep2guu0172-J1CZ_PEwlhl3aKywj1rKQhH-VfNSgT5tu7LRVaMVYUQVYjrTxZJkIs95zUsN3VKsKfQOYg71nejmIa05SJpJTahHqet7rhcTponvQwEJPCe6dehgpnVlIKcT-IJWtSvmbMpVbyr0rEmwBBADpXQvlXOoE8YR7Ye-D6f-MIy8mMaeG1I_AYQyN2CDyA0HSeQmacDcZJCmQUrDYOCzXlVOHTo8WklKaHAyJft93-WgRd4HbTM_HbphOAzc4SCnbpKnaT6gUehHdFvJ7jG6ua7TGTC095eo9ulldWkVKIrF6setavmFpxouc4GkpJNhHFAvQO26Mvc1O_5w33Jg615wR2b4cULvfS2Ulsr9jaU3Uj66n2tJ5stCJMShEUkLVk5dLbIlQebnYuqiEk5w2-vcAg6CLv9RSFs6sZLp5LPVG4veCf2-SeDESIZfVadoCo0-JUyfbMmcpRKvPjDwq1n2GRwSbFJV2IJR_a6uZY3kLjjR9VKUU6IlKSTLgOOAXSUKhv5IMqZZwhRfs3ssmyIjJXCFNeCrGXhZqvc-QnKJPgotOJS-eceoVe-jfE6XpswgPJFTKkKgg6xcEgg3GAgyUYMYWS-tKrn4Cq7Y0cbtgEm6FpAVL9EE5oku5AS6oxoIQAZGqL_TxBcFUl_Twr8ePn18TQO_N6V57gm8ChyA5AWbqjaIRmEcR-SJ1VgDYiPg6xNuGp3yktdM86z3Ld3ADzGIo9Q3JsUq2L8x9YJrCBlw8BHPFg48BUdXum4QTZJJGCHRaVYD5F_gdzOOxLSDGNSvUOLvPCcQ5L4dbQE2Vy8rvhoxUZBDxzA8VdVWGcRE020ILDBUdrVFHw6uuyX386qwtcmejxPdnQvBQQCH4Q6A61EcI2MmTILAgJk0JkJZeN3_NQAmYGh8GxAlq0yCZBwQqI1bOMHNdvXURgeZb9oAZy5hWJ8xZDLhMLinaK2uvNwYD-SghbrJDFtIgZ6OLRiBmBy5qIBam2MFqqlFxpPbdX_Q5N3ejbcfQCvE298zGcUPQjxeFq2PIPT-Ujqw0Cud2RrQC-jSnwvBn0ibt2wG__NR3w8GcDSHLsw28UXmf4BReVLL-YPRF9mfAkMTTuYs46RNlncY-XJ6vQYUuXtMmLClO7oM9qJpTA5V1nDuiy4_M9xYzGPvUMDZdMKEGzuzQJyfmWhcHJ7H4B3v-56uCWJy8uuN_iZJP5eRo-A4x5pgKn4RbmU12U8CzNAqpmeX61QG7_4u3ltOtenEGZzq9Gi-jPXbOpR1p43uZ3WnYR-O0Y51KWHZF5bi9KebSuVo7Hdcf0qMCmiN67pmy0_5Ou-BZifSRFeorcQcpjA1wVSAwGyKcKYEpGPqiVUVMCRZ4vqOZo8cyZI0U8gbSu7aWq6phUtN-6iDuO2lwCNffoTKkG2Qncxg5ddOMP43EOhQsgY5651D--Q3UM12dotRz1Lin_Y9K0kpRWpCXmqmuGZWIGrVYehqslCzcsoxEAEN13SIL4A3R8aWs6Jq5mhbqMIM8wVQu927SFx_LBwf9u7zB-aVcViO9qi5ksXCrO2ZsFoIplDk2JgplfM5TGvNLRuv91kF4zOu7MCvNYqASA8AtwM4_IjyQmx7zlTHQB74Xcy_A8DOiIlvNiptaiYCDmghBTfJI16BfRasaFavUi7Uhc5oAOphmhnurhitXjkZXmo-V9C3lqnbqxTZ_tWI7VdaWymExdOCWSaouDlF91H2dDz5L2eP2GIwHk9MumMu7shalfimCzzkR3-gVcEeq0WSHpTBJQIONmzNuVM-dOJbJ7j5vqC2ttFrH9xICG6JdzY7-6Gx9gE7Q5RrCn2PEJ_I1GunWZilcOMyYMVuQwfgPxbhM-PYN2HrBX8Zy8ZE89M5zHhyX2b8K1lLN_1u3QNI3bY4WLnINtGfh_kolM8McYwQ705_tyA-EbT4Ys0E8RbbtqPBjTkdb8A2RQ69Md8hgfjzDGiH4DwzighgdBBF6N2JgNzw9PjAvjVwrqK7iewrTpugfq2NcZ6h9hjN8kOB_HWecISYs1o5xNQpOhTWTb7z84bvjw2u8LUWXuvy88fvU5j7vKbu01-Z2j8hUzMLv78yjDeFGNENfnYyvDPzfEVq_CPkPi_Ssf8rlzsBihj6o_Byczn72vXn53F_u0F9GF14_rZl2V_52_ebOvDMUuehUHhdVbzMHpoE8DKA3ud3X0HCZggq7eYos7w5LWTCimLZbuYWSbFerwQi1GTOHnHJWuiVzfcxxe64Wgt2rdA93HnVi-MDHRlc2jv3mbEOuqFv3NBsvGzXoXUBtWVlaF6YmmAIs8MT3dBuhUVYzdbjTLBpKZUWqWtlrKBzaCDKtGgyjgPRtzKDXSJ_z8tOI-GhqSpIIXArQIR7xjebSgF4WyJKQyPcYw68wP36w3Z7JyBM3BlnGW7IEIXmNW6rdug17mjOhKoKtrToKJLXck6AfEaWWiqI6MQ-qnrECLKFrTz1nIjtRwlT5IkXRavQxOBrd-WCthZUOlCo8hUf-f1-5Ae-NwyvslGQDYMhu9JCF3y0NgnuBgczgCuknx7Qpvn2nzPMdlwyBpcwbdnNjDYUgifx3rT34t81TEWd9q6auhi9ege9UKoxBI0GlHpXs9GQJb4Xc48NE-4PmTeAUy_1gyhP-l6Q-1cFS3ihsIvQsSsxwj8a-J4XewMaRkEvyfMsTgZxnMf-MElDJ_T4nImihw33ZD29qkdGh6SZKriJLqA2NxnEkWnJ-Uo-a_RM1qP37jvXbsxfXBmVR0bf_wPNUWxd">