<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/57323>57323</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [clang] Refactor TextDiagnostic and SARIFDiagnostic after D131632
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          denik82
      </td>
    </tr>
</table>

<pre>
    D131632 introduces SARIFDiagnostic class which duplicates most of the functionality from TextDiagnostic and adds some improvements/fixes spotted in the code review. Similar concerns have to be addressed in TextDiagnostic. See https://reviews.llvm.org/D131632 for more details.

Overall, the two classes have to be refactored. More likely shared functionality has to be moved into a separate Renderer class.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJxtUV2PmzAQ_DXwsioCEwI88JA2OqkPVaW7_gFjL-CesSN7SS7_vgukH3eqhIx37Z0Zz_Re37tzURbHUoBxFLxeFEZ4OT1_fTobOTofyShQVsYIt8moCfRysUZJ4mszn4IfgCaEYXGKjHfSGrrDEPwMP_CN_gGRToPUOkL0M4KZL8FfcUZHMRFPg3ljwHjxRKhZyoapvEYIeDV4y-DFzMbKwE2nMLgIk7wikIceV9iAMe6T72l5EBEmoktMyhMz8bdDxsza65z5MHLrtwmDD_ysgKCRpLExS_Jzkp_29fsVg7Q2EV82eXTzuzP4TkzAQSpiDJ3BtxXKmle0d4iT5N4HoyYZH2Mzu7Hq50pCxIsM7DE8o9MYMOxEWYpdcTwWommKQ53qrtRt2cqUDFnskuoz33JjUp15bhfxvxA-pisHYoKHA-kSbPfertHQtPSZ8jMXq2eP3ydO8Ccq4tLEuOCaY1WXokynbhgOKi_LvB1qWSHWeX1Ura5qLWTTFscmtbJHG1fNiRAOb7BB8J7Vp6YTuRB5I0qRV9WhztoiH4Za9aqVotU1JoccZ87nT4Rp6DZJ_TJGPrQm0t98U7bOjA43i1Z8udDkQ6fRmddGpBt1t0n_BQPECgM">