<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/56296>56296</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            bugprone-unchecked-optional-access crashes with "Assertion `Cond != nullptr' failed"
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          gburgessiv
      </td>
    </tr>
</table>

<pre>
    When evaluating this check on Chromium, I noted a few crashes. A creduce'd test-case for one of them is below; it repros on 206a6037a093a73d928a60c3012593f921a4f639:

```cpp
typedef int a;
namespace {
namespace base {
template <typename> class Optional {
public:
  operator bool();
};
Optional<a> b(char *);
namespace {
using af = char;
af ag() {
  for (;;)
    ;
  char ah[4];
  Optional ai = b(ah);
  !ai;
}
} // namespace
} // namespace base
} // namespace
```

```
$ clang-tidy '-checks=-*,bugprone-unchecked-optional-access' repro.cpp -- clang -c -std=c++17 -x c++ repro.cpp
clang-tidy: /usr/local/google/home/gbiv/llvm/main/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:100: void clang::dataflow::TerminatorVisitor::VisitForStmt(const clang::ForStmt *): Assertion `Cond != nullptr' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: /usr/local/google/home/gbiv/llvm/main/build/release/bin/clang-tidy -checks=-*,bugprone-unchecked-optional-access repro.cpp -- clang -c -std=c++17 -x c++ repro.cpp
1.      <eof> parser at end of file
2.      ASTMatcher: Processing 'bugprone-unchecked-optional-access' against:
        FunctionDecl (anonymous namespace)::base::(anonymous namespace)::ag : <repro.cpp:11:1, line:17:1>
--- Bound Nodes Begin ---
    T - { BuiltinType : int }
    fun - { FunctionDecl (anonymous namespace)::base::(anonymous namespace)::ag : <repro.cpp:11:1, line:17:1> }
--- Bound Nodes End ---
```

cc @ymand 
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzNVkuP4zYM_jXOhXDgyHmMDznkCRToY4EZtGdZkm11ZcmQ5Ezz70vaGSdtZ7GD2UsDI5YpivxIfqJUOnnd_tEoC-rCTc-jtjXERgcQjRJfwVk4NN61um8TdoCfwLqoJHCo1CsIz0Ojwhx2OFSyFyphGwlRhZgKHhRUzqMFBa5Cm6oFNFsq416TfA86gledd4F8sGzN11m-4VmR800uC_aE3yLPFmxV5FXBFnxZrfMiyXdJdkyyt_91Nj6i60ZJvHZKqgq0jcDRzSi1vFWh40JBsvmPqCSkkzyqtjM8oiQ_kDHSS_ITCMNDgN-6qJ3l5q7f9aXRYsIF4DrlecTAS-dMwp4SVkw4ks1xGr-ZQj-cHJSoKxruIWG7xzXvYO8DVYlXiPEItGZSRhmvR6d3dRjqQFJUwweN3-QA00oYDAFvktV-mayODxNT0FwPHgkp6j1gRDtYIf2PON8GOHXGB6Y4vj0zlOK7C99q_i4Rbp9sSQWzdRq1vKKhTTrQOSD8dMjvoexrJJ9VaW-HKSVTd4sz5UKoEHDVyNA5sgvSdLQIqYA0RImWRMIwmfvFBtK_4PZxXzEiuaNAilBEffD4b5zAyrNz7VxtcNecG9fSqy71habNBbfbueXa4muwQVKNmT8jIcw1aIR3RjOvz8oGHfWFVr8gX0-4J5U88sgrnH1THgDlu0WWEYyL03KMhnib7-RNe_x6Ub7Vlij8u0bTzo_i4ePs_HNsI1HV2RAfjdymJvruYBeC8pRSwMIcnJXEEiKQ7Y3poqcEV1wbJedjsr78fNo9nyD0ZYvdgQPWiPLpfITooImxC-RroEWtY9OXc-Hae77olWL6_1QCIZ51CL2iPAFH39oK00tFjWhsXMg28TV6JNbN_XNEAci-7abtnM1h-H3xrva8Be7rvlU2hs9Xs-y1kfj2yiiiO0ruVR75-gmy_jhTF7dQsR8pV1FH6rjHAgKPoDB_2MMrrNWozG7Ku-eXX3hETEQSyhJhoeaEtf3YDuM1piXEhwY6_s64ipSPShjqXdw6e21dHx76wUAzfIa2MYy-o8gRGBUuP9yDx12xoD863oy2ZGixGQT5aYSUYkb3rscc_OqkCrBXtbaY5vSO-AVS6rewx-LiEUobcfBEx9DUDEmx6u1N9X8R4B3cv4M84WgK8d2eKwQky-za0uaayS0e2nnBZ1FHo7YfIOzt8gCvuJExfvbxboHKs96b7ecbwmrNivWs2cp8mWWVXEv2tFqyIntSnHHFs_Vallm13swMx_tK2OKZiE4tXnkGEzjGE3KmtyxjeHNhBWOL9Wo5zzOJBoqiwvsLrzKB6VG4682ccMydr2d-O0DC9AScNDrEcJ_EC4aurVKDO7TP-9g4v63L3te0rS6zwft2QP83EffybA">