<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/54244>54244</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
Assertion failure when using bolt with shared library and --update-debug-sections
</td>
</tr>
<tr>
<th>Labels</th>
<td>
new issue
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
KenPatrickLehrmann
</td>
</tr>
</table>
<pre>
Hi,
we have an issue with our shared libraries and bolt.
We use the main branch of llvm-project.
We can't manage to make --update-debug-sections work with shared libraries generated by our main compiler.
Even trivial libraries fail, so maybe there's something wrong with our compiler ? I believe we have some custom sections inserted in the shared libraries, are these an issue ?
```
/opt/1A/toolchain/x86_64-v19/bin/g++ --version
g++ (GCC) 9.2.1 20200225
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```
Here is a simple example, with the following test.cpp:
```cpp
void f(){}
```
`/opt/1A/toolchain/x86_64-v19/bin/g++ test.cpp -march=broadwell -fPIC -shared -o test.so.1.1 -g `
Here's the resulting .so:
[test.zip](https://github.com/llvm/llvm-project/files/8196570/test.zip)
cat p.fdata
```
1 _init/1 e 1 _init/1 12 0 1
```
```
llvm-bolt test.so.1.1 -o test.bolt.so.1.1 --data p.fdata --update-debug-sections
BOLT-INFO: shared object or position-independent executable detected
BOLT-INFO: Target architecture: x86_64
BOLT-INFO: BOLT version: 46266b3518b6190d4eaa8e4920371c87fd784f46
BOLT-INFO: first alloc address is 0x0
BOLT-INFO: creating new program header table at address 0x200000, offset 0x200000
BOLT-INFO: disabling -align-macro-fusion in non-relocation mode
BOLT-INFO: enabling lite mode
BOLT-INFO: pre-processing profile using branch profile reader
BOLT-WARNING: Ignored 0 functions due to cold fragments.
BOLT-INFO: 1 out of 8 functions in the binary (12.5%) have non-empty execution profile
BOLT-INFO: 0 instructions were shortened
BOLT-INFO: UCE removed 0 blocks and 0 bytes of code.
BOLT-INFO: SCTC: patched 0 tail calls (0 forward) tail calls (0 backward) from a total of 0 while removing 0 double jumps and removing 0 basic blocks totalling 0 bytes of code. CTCs total execution count is 0 and the number of times CTCs are taken is 0.
BOLT: 1 out of 9 functions were overwritten.
BOLT-INFO: rewritten functions cover 100.00% of the execution count of simple functions of this binary
BOLT-INFO: patched build-id (flipped last bit)
llvm-bolt: /home/klehrmann/src/llvm-project/bolt/lib/Core/DebugData.cpp:647: virtual std::__cxx11::string llvm::bolt::DebugInfoBinaryPatcher::patchBinary(llvm::StringRef): Assertion `Offset + ByteSequence.size() <= BinaryContents.size() && "Applied patch runs over binary size."' failed.
#0 0x00007f780059526c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /home/klehrmann/src/llvm-project/llvm/lib/Support/Unix/Signals.inc:565:0
#1 0x00007f7800595323 PrintStackTraceSignalHandler(void*) /home/klehrmann/src/llvm-project/llvm/lib/Support/Unix/Signals.inc:632:0
#2 0x00007f7800592fd2 llvm::sys::RunSignalHandlers() /home/klehrmann/src/llvm-project/llvm/lib/Support/Signals.cpp:97:0
#3 0x00007f7800594bed SignalHandler(int) /home/klehrmann/src/llvm-project/llvm/lib/Support/Unix/Signals.inc:407:0
#4 0x00007f77ffde2f60 (/lib/x86_64-linux-gnu/libc.so.6+0x43f60)
#5 0x00007f77ffde2ed7 raise /build/glibc-KRRWSm/glibc-2.29/signal/../sysdeps/unix/sysv/linux/raise.c:51:1
#6 0x00007f77ffdc4535 abort /build/glibc-KRRWSm/glibc-2.29/stdlib/abort.c:81:7
#7 0x00007f77ffdc440f _nl_load_domain /build/glibc-KRRWSm/glibc-2.29/intl/loadmsgcat.c:1177:9
#8 0x00007f77ffdd4012 (/lib/x86_64-linux-gnu/libc.so.6+0x35012)
#9 0x00007f77fe379f3c llvm::bolt::DebugInfoBinaryPatcher::patchBinary[abi:cxx11](llvm::StringRef) /home/klehrmann/src/llvm-project/bolt/lib/Core/DebugData.cpp:646:0
#10 0x00007f780399625d llvm::bolt::RewriteInstance::rewriteNoteSections() /home/klehrmann/src/llvm-project/bolt/lib/Rewrite/RewriteInstance.cpp:3830:0
#11 0x00007f7803998250 llvm::bolt::RewriteInstance::rewriteFile() /home/klehrmann/src/llvm-project/bolt/lib/Rewrite/RewriteInstance.cpp:5093:0
#12 0x00007f7803981f68 llvm::bolt::RewriteInstance::run() /home/klehrmann/src/llvm-project/bolt/lib/Rewrite/RewriteInstance.cpp:784:0
#13 0x0000558b68656cf2 main /home/klehrmann/src/llvm-project/bolt/tools/driver/llvm-bolt.cpp:255:0
#14 0x00007f77ffdc5b6b __libc_start_main /build/glibc-KRRWSm/glibc-2.29/csu/../csu/libc-start.c:342:3
#15 0x0000558b686556ba _start (/home/klehrmann/src/llvm-project/buildnodocker/bin/llvm-bolt+0xf6ba)
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0. Program arguments: llvm-bolt test.so.1.1 -o test.bolt.so.1.1 --data p.fdata --update-debug-sections
Aborted (core dumped)
```
Any idea what is going wrong ?
We'd gladly share more information if need be.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzdWVlv4zgS_jXOC2FBt-yHPDhOPG1MbxLYaTT2yaBEyuZEErUkFcfz66eKkuIj7t5OzzSSXcKQJYpFfnWwDiqVbHf5SQz86cC9HriT9rrlZEOfOKEVEVo3nGyF2RDZKKI3VHFGCpEqqgTXMISRVBbGaSm_ctJoTsyGk5KKisCwKgPSnBTFUzmslfyDZ_3gF5KMVgM_MUBS0TVQS7h75GQ4bGpGDR8ynjbroQZKIStNtlI9tpBewVnziisgAVA7C9iiyGRZi4Krbt2bJ14Ro8SToMUBbU5FAYIgGpffpZYLxQGYhq6Sm42o1mSrJF57efQzk0EwI3OS8kJwEFwvQKQjWaONLMkLfFFprhAiIENBnTKBGKAH3-kDHcAKh2IbxG73ax_9mawNXD28NVIW2QZYh_vnUbyKw-GTN4aH1HatB_4V_EDAT1xpANXO0XcP_NFv0-nAH5Ox4zse8V3fdX0_akdNZb1TYr0xOM6O8l1vTGaKc7KUudki9plsKlAdTg3czKusE_3DRoAAQNY4WnejB8EVSKe1Gg1SzTjJJcq23qHIM1kxYUXnEPKAOsEZbu86W6UKbMzscJJKGsJRuUj-r5vF9NPk9mFyNf88f_g3ga7Z_OH2Zrkks7sFmZD7yeJhPv3yebIg918W93fLG-e8aO31U7cuJVqUdcEJf6b4j_xZc0D0uSwKuUXQhmvjZHU9CE71hZ2250kKRnIQIshwkFwNkuvzy8PNzyi3R0CGJVXZZhBcp0pStuVFQYb5_XxKhp3lDWU7WEvHA3UTMlyTM9zbnYBcKq6bwiCXQPLCIGlbRxVd2Sn_FPUgugYeN8bUGsf6M8QIAmtSB3YPPKBn6P56BwGPOWwr2AqzkTeOowRF8DIhiOtgxUOYGTWkdnKwPHpWlh5ZiUpYSRJODp88n7jE-84GI_8P7YSz94bzT7eWPWtIGJOOrLo3chus-r4hWkpvMeSbAefdW8vY1d3nh-H8dnYH-6iPGjLF_YLOrZbaesmhqBivOVwq8IbPPGsMTcFfMW5gJJB8rHaGtQeq1twQ9FoCMTcYIiak9XXvjfdN7Qxz-ED6sAvPYezHcRpE3iiNvbHLQk7piIdj3w0SLxslOUtGYR7G783K63aGuVwoDYqDIJgRyhgEChvt3ef_MVdzhrVMcWpjXsW3BMLUWtGSbDhlkPy1GwxiT8-z-wwZEzRMDmSea7Dmvuu9WTvLHBMaWEDuhrQQ6wpShkzJYd6glWKeWoFfURzUanM6UkrG35uNc-0Ma7zqOCvAl3xY4P-9nWGtVhwTpgwsDhmEW0yaoADDp67y6jtVa6kfsh2w9nWyuJ3f_obczdeVxAjnkrypukDMGlsdZrKAzFnRdQkxDquCD9vOaM2DwtFgRTw6YKwrBSGDp2qHhZXnO9EASi4or2wliRuQl7XZdSEdd2Gv2w_GoIsVrlFNX61j4aQ3Ekre6sNlH99rZ1j7Mr2BnVTKJ2uXKfjDx_YIBB52kF6iWjNwMc436JfTh6ndudRkGzuHoaIgGURMjVp3sXKFipah3k9fpTR77N_lSpZQihppaIGLumS7abc5gMPt7xImG4xKfzRl3WI8eJdSLbIev52k6F4ccwFwu_cHZpdBbW9sWLfTot1WTZmCdwE6I0qYwNLZMwz6yCs71tmL42gXjA92gTUVEK7aKmHAXJwzIlS8e3lAlyEN8VzXwZAbWRwb_goydHe1-57UDgV87c4752Q7VaWNKNgQKnbQRV6IusYjGwrZTooV5Pik9EBKqCs3soSyefZY8I0qaYXluVbZ62LXkkCvSOE6lVhrz66xBrmGuqQ7RojDBGd9Eso0oA9tGJbTwWS1yp6fPa99gH1nYx2W1LajAwM_O9-8yuWVZfXe8qXad5bJth_Y21Mv7XQLniOHsPhE49EVShSqx7s2scGzhiswmyX_T8OrjDta_MnbUw0yCMDcr0k781RWxvrrwwF-DD_48yd1XQiQqYVCVIO6Qa12LhFpHBg28BN7UMdZZxxAG7iYYUJL8mTkutE48uPsQAZ6p9ube-DGLA3sowdFM37EqqLblQTxcVpaUFPwYqaF-MNq7E8yrBqXTV2D04O7L5V4xg5IrGihHVFlsF4UR3B190x4p0wEfkBOELdTfIJtV4Dq_BEeIQ38yS-EGQf-MUz_BKafM_-crBdNdYRWv2j87-LsAbbbYpwc4wtO8IUpGNWp3H6takP3BFO4x5TkOeN-HrvEyqObsDvGAyfcPA_XVdO-yPCcAkzxyn0OgxyPAcf7OaPTOTlLiKJCc2TLeis8aMNphr8vFl-X5cuj7_h4XKgtaLhxHHzaacZrPHFrWp6g48niAEzwb6d2rOWir_H2SOJjJFkYATiagoB-GIlhrRwslV1khIsk-0WS00VCNyerqlgVkrIVk_ac_weXA-0j20hZ6jWUNHZFz0tQbQciHh2vyULX89-mtiACkiO1jQ_n5EEyzoPsb7nr6IqmAvraIGDPWs_7738-HsV7K0f_deSFg_E49iN2lrWFDeF8Dlki1Ci8879t563ESNIG57d7jCPc3TL7u37BjoFgFLjHHHgnHIz8yH0zBzNR8F-MPHLHwTFy_xj5yMvj0RuQN9UvRpyMwmPAvZuOolEaj-IoznKf9Jv4jRDwgwg6LqbEE7r32Usa1q3uR9Hx6icOOYvSOCWrFW7eFeBWZvUWf5Lppvei7a19aeexniUIMYYG--WjE-ajOKWkXbjzLz8sAYRXSQaJvOW8_QS0T0PRCeUw-4sPuv98M1neEN2kpTBQQcCehpQaoxkW1m_-SmM_TaLsbSkA4a9oWPshL1NUb2zNYjBz6bI1m8pAGV_uP4y5Xf1-352pUbVubF2PCedPn-V_4yi_XXKCYYbbVD4D52bxcPYio-98BZxUOyIYp1BuUVsDreX-q_DLF9qv-K2MkXVBWbFrT-pJiQsJ8OegT5tBi5xUHAsL7lywy4CNgzG9MMIU_HKfZmOq2wDhdgMFT3ewg9J4_fV7ZzXwDbYvGlVc_rxyo9APw4vNJaUh2LLvpknMOM9TbxykUcI9jyUB87LwoqApL_QlBCVI1fGg1E6BaXt0fSEufReIAzdxx5Hn-05E85x6PA1CN4pjRgehy2HfFQ7icKRaX6jL1gCatYaXhdBQPby8pBozGM7tcjA_bcxGqsvfeQXBUons8XO3eS4sikvLxV8rxgTF">