<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=http://email.email.llvm.org/c/eJylks2u0zAQhZ8m2YxulDppb7PIolAhFixBLK-ceBIPuHZlOynl6Rk7ggK6YoMUJZkfn_PZnsGpe_9RI4yL92gjSLXSiEABJufhM1nlbgGWgAGig1Hj-NUtESbvLjBThBtFDcWhlkt0ozdT0ZwnaQJyqhBv4aZp1HD1GNCvrPHJ0jcwZBHQKrJzAGchJv-kjAqyOBkMVVGfi_q0vd-7G67oN0W02VCpF4u3l7ywut45laj9YhMoV0EC12E00s5PkdR980gaidtTZJ5kJ43JCNl225CVkVb8E1RaxW3JAsNiYgDayC9O0USMvq3XcuV24NzER6ZlhCDvUAih0GDEX25Jm_2nHDizLc8mmf21rrSd1MVij7NloMUqDOTlYLAqVd-orulkyTeine8_4CwNfceTYmjtnCoXb3od4zUUzakQ7_jhi9TLUI3uwoEx68_P09W7LzhGDimEBQP_7EV3OJa6r0d1VGo3Hg4H8XxQdd022O0G2YlOiudJlEYOaEJf7N8wb0LPEol9fy7_n4B6UQtR7-pm14lWtNV-OE67qW7F0DZd3U1FW-NFkqmSTuX8XPo-Sw7LHLhoKMTwKMoQaLaIGZgJI0WTg8cAcRr-HrvfB-nfA1TmDfSZ_gfnDC3R>52968</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
[clang-tidy] add_new_check.py writes out files with native line endings
</td>
</tr>
<tr>
<th>Labels</th>
<td>
new issue
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
LegalizeAdulthood
</td>
</tr>
</table>
<pre>
The current advice is for Windows uses to checkout from git with `autocrlf=false`, which preserves Unix line endings on the checked out files.
However, when `add_new_check.py` is run to add a new clang-tidy check, it writes out all the files with native line endings and this results in the modified files having diffs that say "delete all the lines of the old file and add all the lines of the new file", which is undesirable.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJx9kkGvlDAQxz8NXCaPsAX2LQcOqxvjwaPG40uhAx3ttpu2sK6f3mmJPjXGhECnM_3_fzN0dOoxfNQI0-o92ghSbTQhUIDZefhMVrl7gDVggOhg0jh9dWuE2bsrLBThTlFDcazlGt3kzVw0l1magLxViLdw1zRpuHkM6DfW-GTpGxiyCGgV2SWAsxCTf1JGBVmcDIaqqC9Ffd7f790dN_S7ItpsqNSLxftLPljdHryVqP1qEyhnQQLnYTLSLk-R1GP3SBqJ21NknmQnjckI2XZvyMpIG_4JKq3ismSBYTUxAO3kV6doJkbfz2u5cTnw3swj0zJCkA8ohFBoMOIvt6TN_nMOnNmPZ5PM_q-q1E6qYrHX2TLQahUG8nI0WJVqaFTf9LKMFA0ORffmdQJFd4G_5_b7JP4_gXL1ZtAx3kLRnAvxjh--AXodq8ldOTBm-_l5unn3BafIIYWwYuBFJ_rjqdTDNArZdao7dM9K9n3X9arl4Hh6nvqxHdvSyBFNSOTcaOo5S6Smu0tJg6iFqA91c-hFK9qqG0_zYa5bMbZNX_dz0dZ4lWSqxFE5v5R-yEjjugROGgoxvCZlCLRYzINK-nyPtfPDB1ykoe94VvyrtXOqzBBDbuIHcZoYNw">