<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:aardappel@gmail.com" title="Wouter van Oortmerssen <aardappel@gmail.com>"> <span class="fn">Wouter van Oortmerssen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - WebAssembly .s format can omit .globaltype for __stack_pointer"
href="https://bugs.llvm.org/show_bug.cgi?id=51555">bug 51555</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>CONFIRMED
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - WebAssembly .s format can omit .globaltype for __stack_pointer"
href="https://bugs.llvm.org/show_bug.cgi?id=51555#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - WebAssembly .s format can omit .globaltype for __stack_pointer"
href="https://bugs.llvm.org/show_bug.cgi?id=51555">bug 51555</a>
from <span class="vcard"><a class="email" href="mailto:aardappel@gmail.com" title="Wouter van Oortmerssen <aardappel@gmail.com>"> <span class="fn">Wouter van Oortmerssen</span></a>
</span></b>
<pre>Thanks for reporting, and figuring out the problem!
The point of MachineSymbolsUsed is that they are indeed all collected before
emitExternalDecls ever gets called, but that wasn't happening, because the pass
that does so, WebAssemblyMCLowerPrePass, was a FunctionPass which can get
scheduled interleaved with the AsmPrinter.
This patch changes it to a ModulePass to fix that:
<a href="https://reviews.llvm.org/D109202">https://reviews.llvm.org/D109202</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>