<html>
    <head>
      <base href="https://bugs.llvm.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Clang recommends `string.h` for missing `strndup` declaration"
   href="https://bugs.llvm.org/show_bug.cgi?id=50786">50786</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Clang recommends `string.h` for missing `strndup` declaration
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>clang
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>12.0
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Windows NT
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>enhancement
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>C
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedclangbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>prs.ttg+llvm@pm.me
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>blitzrakete@gmail.com, dgregor@apple.com, erik.pilkington@gmail.com, llvm-bugs@lists.llvm.org, richard-llvm@metafoo.co.uk
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Clang recommends `string.h` for missing `strndup` declaration despite `strndup`
not being part of `string.h` under the Windows libc.

This means that compilation of something like this:
```
#include <string.h>

char* test(const char* str, size_t n) {
    return strndup(str, n);
}

...

```
would result in:
```
implicitly declaring library function 'strndup' with type 'char *(const char *,
unsigned long long)' [-Wimplicit-function-declaration]
        return strndup(str, n);
                       ^
note: include the header <string.h> or explicitly provide a declaration for
'strndup'
```
which is quite misleading.

I'm not sure if there is a way to see whether a given header provides a decl
under a given compilation env, or if it would just be a case of not treating
`strndup` as a library function on windows targets.

This came to light from GH Actions CI so I can't really provide many more
details on the environment - clang seems to be installed from
'<a href="https://github.com/llvm/llvm-project/releases/download/llvmorg-12.0.0/LLVM-12.0.0-win64.exe">https://github.com/llvm/llvm-project/releases/download/llvmorg-12.0.0/LLVM-12.0.0-win64.exe</a>'
(using `egor-tensin/setup-clang@v1` for the action)</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>