<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - SplitEmptyRecord also affects whether to SplitEmptyFunction"
href="https://bugs.llvm.org/show_bug.cgi?id=50707">50707</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>SplitEmptyRecord also affects whether to SplitEmptyFunction
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>lichray@gmail.com
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=24952" name="attach_24952" title="test case">attachment 24952</a> <a href="attachment.cgi?id=24952&action=edit" title="test case">[details]</a></span>
test case
Given the following .clang-format file:
---
BasedOnStyle: Microsoft
AccessModifierOffset: '-4'
AllowAllConstructorInitializersOnNextLine: 'false'
ConstructorInitializerAllOnOneLineOrOnePerLine: 'true'
AllowShortFunctionsOnASingleLine: Empty
BreakConstructorInitializers: AfterColon
ColumnLimit: '80'
Language: Cpp
Standard: Latest
BraceWrapping:
SplitEmptyFunction: true
SplitEmptyRecord: false
...
Long function bodies are not becoming
{
}
Expects (test.cc): --
class Short
{};
class Test
{
public:
Test() :
bEnabled(false),
eDestination(eOutputDestination::file),
uiMaxSize(DEFAULT_MAX_LOGGER_FILE_SIZE)
{
}
void memFun(void *caller, std::function<int(char const *, char)> cb,
std::tuple<bool, std::string> param)
{
}
};
void regularFun(void *caller, std::function<int(char const *, char)> cb,
std::tuple<bool, std::string> param)
{
}
Got: --
class Short
{};
class Test
{
public:
Test() :
bEnabled(false),
eDestination(eOutputDestination::file),
uiMaxSize(DEFAULT_MAX_LOGGER_FILE_SIZE)
{}
void memFun(void *caller, std::function<int(char const *, char)> cb,
std::tuple<bool, std::string> param)
{}
};
void regularFun(void *caller, std::function<int(char const *, char)> cb,
std::tuple<bool, std::string> param)
{}
Trying out all 4 combinations of SplitEmptyFunction and SplitEmptyRecord and
got a surprising result.
SplitEmptyFunction: false
SplitEmptyRecord: false
Good
SplitEmptyFunction: true
SplitEmptyRecord: false
Bad, same as above
SplitEmptyFunction: false
SplitEmptyRecord: true
Good
SplitEmptyFunction: true
SplitEmptyRecord: true
Good</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>