<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:rnk@google.com" title="Reid Kleckner <rnk@google.com>"> <span class="fn">Reid Kleckner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Recent shared_ptr storage change (https://reviews.llvm.org/D91201) causes CFI cast failures during make_shared"
href="https://bugs.llvm.org/show_bug.cgi?id=48993">bug 48993</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Recent shared_ptr storage change (https://reviews.llvm.org/D91201) causes CFI cast failures during make_shared"
href="https://bugs.llvm.org/show_bug.cgi?id=48993#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Recent shared_ptr storage change (https://reviews.llvm.org/D91201) causes CFI cast failures during make_shared"
href="https://bugs.llvm.org/show_bug.cgi?id=48993">bug 48993</a>
from <span class="vcard"><a class="email" href="mailto:rnk@google.com" title="Reid Kleckner <rnk@google.com>"> <span class="fn">Reid Kleckner</span></a>
</span></b>
<pre>I think we can declare this fixed, but this issue is likely to pop up again in
other places because std::construct_at expects T*, and that requires casting a
pointer to uninitialized memory. The old way of doing this, placement new,
expects a void*. Adding a new CFI testing configuration for libc++ will be the
best way to detect such issues in the future.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>