<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [AMDGPU][MC] Common code patterns in parser"
href="https://bugs.llvm.org/show_bug.cgi?id=48515">48515</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[AMDGPU][MC] Common code patterns in parser
</td>
</tr>
<tr>
<th>Product</th>
<td>libraries
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Backend: AMDGPU
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dpreobrazhensky@luxoft.com
</td>
</tr>
<tr>
<th>CC</th>
<td>llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>AMDGPU parser code has repeatedly used patterns which could be simplified.
Examples:
if (getLexer().isNot(X)) {
return ERR_CODE;
} Parser.Lex(); --> if (!trySkipToken(X)) return ERR_CODE;
Parser.getTok().getLoc() --> getLoc()
Parser.getTok().getString() --> getTokenStr()
Parser.getTok() --> getToken()
getLexer().getKind() == X --> isToken(X)
getLexer().getKind() --> getTokenKind()
getLexer().is(X) --> isToken(X)
getLexer().isNot(X) --> !isToken(X)
Parser.Lex() --> lex()</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>