<html>
    <head>
      <base href="https://bugs.llvm.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - attribute instantiation for class template specializations can lead to deserialization cycles"
   href="https://bugs.llvm.org/show_bug.cgi?id=48434">48434</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>attribute instantiation for class template specializations can lead to deserialization cycles
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>clang
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>enhancement
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Modules
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedclangbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>richard-llvm@metafoo.co.uk
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>dgregor@apple.com, llvm-bugs@lists.llvm.org, richard-llvm@metafoo.co.uk
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Consider:

```
template<typename T> struct A;
using X = A<int>;
template<typename T> struct [[attr(X)]] A {};
X x;
```

Now, deserializing `x` crashes, because it hits a cycle:

* Deserializing `x` reads the TypedefNameDecl `X`
* Deserializing `X` reads its RecordType `A<int>`
* Deserializing `A<int>` reads its attributes
* Deserializing `attr(X)` finds we already have an `X`, so tries to use it
* Using the `X` to form a `TypedefType` crashes, because `X` is not
sufficiently initialized

This is broken because we violated the deserialization invariant by emitting
bitcode for `X` that (indirectly) refers to a lexically-later part of the
program, specifically the attributes for `A<int>`.

To fix this, I think we need to lazily load attributes, at least for template
specializations.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>