<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:spatel+llvm@rotateright.com" title="Sanjay Patel <spatel+llvm@rotateright.com>"> <span class="fn">Sanjay Patel</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [VectorCombine] Generated code no longer uses horizontal add/sub"
href="https://bugs.llvm.org/show_bug.cgi?id=45747">bug 45747</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [VectorCombine] Generated code no longer uses horizontal add/sub"
href="https://bugs.llvm.org/show_bug.cgi?id=45747#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [VectorCombine] Generated code no longer uses horizontal add/sub"
href="https://bugs.llvm.org/show_bug.cgi?id=45747">bug 45747</a>
from <span class="vcard"><a class="email" href="mailto:spatel+llvm@rotateright.com" title="Sanjay Patel <spatel+llvm@rotateright.com>"> <span class="fn">Sanjay Patel</span></a>
</span></b>
<pre>Simon added more x86 codegen combiner magic to clean this up with:
<a href="https://github.com/llvm/llvm-project/commit/182111777b4ec215eeebe8ab5cc2a324e2f055ff">https://github.com/llvm/llvm-project/commit/182111777b4ec215eeebe8ab5cc2a324e2f055ff</a>
And that got backported to the 11.0 release (<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Merge bfc4294ef61d5cf and 182111777b4ec21 into 11.0 release branch"
href="show_bug.cgi?id=46869">bug 46869</a>).
So I think it's safe to close this one. The 1st test is improved to a single
hadd (no shuffle), and the 2nd test uses vpermilps which should have the same
perf as vmovshdup.
$ clang 45747.c -S -O2 -S -o - -march=btver2
_add_ps_002: ## @add_ps_002
vhaddps %xmm0, %xmm0, %xmm0
retq
_add_ps_013: ## @add_ps_013
vhaddps %xmm1, %xmm1, %xmm0
vpermilps $231, %xmm0, %xmm0 ## xmm0 = xmm0[3,1,2,3]
retq</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>