<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - clang-format deletes whitespace before ref-qualifier in user-defined conversion type-id"
href="https://bugs.llvm.org/show_bug.cgi?id=45992">45992</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>clang-format deletes whitespace before ref-qualifier in user-defined conversion type-id
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>10.0
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>jfreeman08@gmail.com
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>Compare two consecutive commits:
- parent:
<a href="https://github.com/ripple/rippled/commit/97712107b71a8e2089d2e3fcef9ebf5362951110">https://github.com/ripple/rippled/commit/97712107b71a8e2089d2e3fcef9ebf5362951110</a>
- child:
<a href="https://github.com/ripple/rippled/commit/fdf6b09433cb4ca9872b89ed3419e0f594523442">https://github.com/ripple/rippled/commit/fdf6b09433cb4ca9872b89ed3419e0f594523442</a>
The file `src/test/unit_test/SuiteJournal.h` is unchanged between them. They
both had checks that ran clang-format on that file. You can find the logs of
the checks by clicking the red x or green check in the top left before the
commit message, then clicking "Details" for "clang-format / check". I'll link
them here:
- parent: <a href="https://github.com/ripple/rippled/runs/647802934">https://github.com/ripple/rippled/runs/647802934</a>
- child: <a href="https://github.com/ripple/rippled/runs/687680298">https://github.com/ripple/rippled/runs/687680298</a>
They ended up running two slightly different versions of clang-format available
on different days through the official PPA (check the "Install clang-format"
step):
- parent: 10.0.1~++20200504072809+8e7ae355ba9-1~exp1~20200504054307.155
- child: 10.0.1~++20200518104422+eaae6dfc545-1~exp1~20200518085019.161
The latter version reformatted the file `src/test/unit_test/SuiteJournal.h`
while the earlier did not:
```
--- a/src/test/unit_test/SuiteJournal.h
+++ b/src/test/unit_test/SuiteJournal.h
@@ -98,7 +98,7 @@ public:
: sink_(partition, threshold, suite), journal_(sink_)
{
}
- operator beast::Journal &()
+ operator beast::Journal&()
{
return journal_;
}
```
I'm not sure if this was a bug fix or a bug introduction. I'm calling it a bug
only because from my perspective, I am getting non-determinism even when
following the official install instructions for one major version of
clang-format, and even when those instructions installed the same patch
version, if I'm reading it correctly. If there is another way we can pin an
even more specific version of clang-format to install, or otherwise guarantee
consistent formatting day-to-day, please let me know.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>