<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - AllowShortIfStatementsOnASingleLine: WithoutElse broken"
href="https://bugs.llvm.org/show_bug.cgi?id=45338">45338</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>AllowShortIfStatementsOnASingleLine: WithoutElse broken
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>pablomg+llvm@eskapa.be
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>$ cat test.cpp
int main() {
if (true) { function(); }
if (true) function();
if (true) { function(); } else function();
if (true) { function(); } else { function(); }
if (true) function(); else function();
if (true) function(); else { function(); }
}
$ clang-format test.cpp -style="{BasedOnStyle: google, BreakBeforeBraces:
Allman, AllowShortBlocksOnASingleLine: Always,
AllowShortIfStatementsOnASingleLine: WithoutElse}"
int main()
{
if (true) { function(); }
if (true) function();
if (true) { function(); }
else
function();
if (true) { function(); }
else
{
function();
}
if (true)
function();
else
function();
if (true)
function();
else
{
function();
}
}
According to the clang-format 11 documentation,
AllowShortIfStatementsOnASingleLine: WithoutElse means the following: "Without
else put short ifs on the same line only if the else is not a compound
statement.". So the expected result should be:
$ clang-format test.cpp -style="{BasedOnStyle: google, BreakBeforeBraces:
Allman, AllowShortBlocksOnASingleLine: Always,
AllowShortIfStatementsOnASingleLine: WithoutElse}"
int main()
{
if (true) { function(); }
if (true) function();
if (true) { function(); }
else
function();
if (true)
{
function();
}
else
{
function();
}
if (true) function();
else
function();
if (true)
function();
else
{
function();
}
}
I don't use BreakBeforeBraces: Attach but it seems broken too:
$ ../bin/clang-format test.cpp -style="{BasedOnStyle: google,
BreakBeforeBraces: Attach, AllowShortBlocksOnASingleLine: Always,
AllowShortIfStatementsOnASingleLine: WithoutElse}"
int main() {
if (true) { function(); }
if (true) function();
if (true) {
function();
} else
function();
if (true) {
function();
} else {
function();
}
if (true)
function();
else
function();
if (true)
function();
else {
function();
}
}
Might be related to <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - AllowShortIfStatementsOnASingleLine not working if an "else" statement is present"
href="show_bug.cgi?id=25010">bug 25010</a> (<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - AllowShortIfStatementsOnASingleLine not working if an "else" statement is present"
href="show_bug.cgi?id=25010">https://bugs.llvm.org/show_bug.cgi?id=25010</a>) but
I'm not sure.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>