<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:lhames@gmail.com" title="Lang Hames <lhames@gmail.com>"> <span class="fn">Lang Hames</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - IR with double constant doesn't work with OrcJIT build by MSVC"
href="https://bugs.llvm.org/show_bug.cgi?id=44337">bug 44337</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - IR with double constant doesn't work with OrcJIT build by MSVC"
href="https://bugs.llvm.org/show_bug.cgi?id=44337#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - IR with double constant doesn't work with OrcJIT build by MSVC"
href="https://bugs.llvm.org/show_bug.cgi?id=44337">bug 44337</a>
from <span class="vcard"><a class="email" href="mailto:lhames@gmail.com" title="Lang Hames <lhames@gmail.com>"> <span class="fn">Lang Hames</span></a>
</span></b>
<pre><span class="quote">> I have ported your patch from #40074 to LLVM 9.0.0 and tested it in the mine environment.
> Your patch is working fine for me.
> Also, it fixes <a class="bz_bug_link
bz_status_NEW "
title="NEW - Basic OrcJIT functional doesn't work with MSVC"
href="show_bug.cgi?id=44336">bug #44336</a>.</span >
That's great news. :)
Ok -- closing this as fixed by 84217ad6611.
<span class="quote">> But are you sure that it is a good idea to pass a parameter by value?
> Error defineMaterializing(SymbolFlagsMap SymbolFlags);
> If you don't want to modify the map, a constant reference is a better solution, if you want to modify, a non-constant reference or pointer is more applicable here, in my opinion.</span >
The JITDylib::defineMaterializing method makes modifications to the map based
on what definitions are accepted and rejected, and returns these to
MaterializationResponsibilty::defineMaterializing so that it can update the
responsibility set. Since these modifications are not interesting to the
client, it makes sense to pass by value: It is cheap, and if the client does
not need their value any more then no copies are required.
<span class="quote">> One more question for you: is removing a module from OrcJIT will be available in LLVM 10?</span >
Unfortunately support for removing modules will not make it in to LLVM 10. The
best solution for now is to maintain a separate ExecutionSession for code that
you want to throw away. I am working on removable module support, and hope to
get it in to LLVM 11.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>