<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:fedor.v.sergeev@gmail.com" title="Fedor Sergeev <fedor.v.sergeev@gmail.com>"> <span class="fn">Fedor Sergeev</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - simple-loop-unswitch is too aggressive in unswitching leading to compile-time issues"
href="https://bugs.llvm.org/show_bug.cgi?id=39544">bug 39544</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>CONFIRMED
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - simple-loop-unswitch is too aggressive in unswitching leading to compile-time issues"
href="https://bugs.llvm.org/show_bug.cgi?id=39544#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - simple-loop-unswitch is too aggressive in unswitching leading to compile-time issues"
href="https://bugs.llvm.org/show_bug.cgi?id=39544">bug 39544</a>
from <span class="vcard"><a class="email" href="mailto:fedor.v.sergeev@gmail.com" title="Fedor Sergeev <fedor.v.sergeev@gmail.com>"> <span class="fn">Fedor Sergeev</span></a>
</span></b>
<pre>(In reply to Vivek Pandya from <a href="show_bug.cgi?id=39544#c4">comment #4</a>)
<span class="quote">> This seems to be fixed. I am not able to repro.</span >
Yep fixed by:
commit 2e3e224e715eeb85ca9640e19ce14cd0bd4f3f6b
Author: Fedor Sergeev <<a href="mailto:fedor.sergeev@azul.com">fedor.sergeev@azul.com</a>>
Date: Fri Nov 16 21:16:43 2018 +0000
[SimpleLoopUnswitch] adding cost multiplier to cap exponential unswitch
with
We need to control exponential behavior of loop-unswitch so we do not get
run-away compilation.
Suggested solution is to introduce a multiplier for an unswitch cost that
makes cost prohibitive as soon as there are too many candidates and too
many sibling loops (meaning we have already started duplicating loops
by unswitching).
It does solve the currently known problem with compile-time degradation
(PR 39544).
Tests are built on top of a recently implemented CHECK-COUNT-<num>
FileCheck directives.
Reviewed By: chandlerc, mkazantsev
Differential Revision: <a href="https://reviews.llvm.org/D54223">https://reviews.llvm.org/D54223</a>
llvm-svn: 347097</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>