<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [clang-format] BreakConstructorInitializers doesn't preserve NOLINT comments"
href="https://bugs.llvm.org/show_bug.cgi?id=41783">41783</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[clang-format] BreakConstructorInitializers doesn't preserve NOLINT comments
</td>
</tr>
<tr>
<th>Product</th>
<td>new-bugs
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>new bugs
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dennis.felsing@sap.com
</td>
</tr>
<tr>
<th>CC</th>
<td>htmldeveloper@gmail.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>$ cat .clang-format
Language: Cpp
BreakConstructorInitializers: AfterColon
CommentPragmas: 'NOLINT'
$ cat x.cpp
class C
{
public:
C(C&& rhs) : // NOLINT(performance-noexcept-move-constructor)
x(rhs.x),
y(rhs.y)
{}
private:
int x;
int y;
};
$ clang-format x.cpp
class C {
public:
C(C &&rhs) :
// NOLINT(performance-noexcept-move-constructor)
x(rhs.x), y(rhs.y) {}
private:
int x;
int y;
};
After clang-format's reformatting the NOLINT marker loses its meaning for
clang-tidy. In this instance a NOLINTNEXTLINE could be used instead as a
workaround from clang-tidy's side.
Unfortunately even CommentPragma can't preserve the comment on the same line.
The only workaround I found is setting BreakConstructorInitializers:
BeforeComma, but in our case this is not wished.
Ideally the comment would stay on the same line and only the x(rhs.x), ... part
be broken over to the next line.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>