<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - clang-format sorts headers even when /* clang-format off */ is used"
href="https://bugs.llvm.org/show_bug.cgi?id=39646">39646</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>clang-format sorts headers even when /* clang-format off */ is used
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>7.0
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Macintosh
</td>
</tr>
<tr>
<th>OS</th>
<td>MacOS X
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>nick.randall@booking.com
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>When files include "/* clang-format off */" right at the top, this is ignored
and headers are sorted anyway.
Changing this instead to "// clang-format off" makes it work as expected and
not sort the headers.
Looking through Format.cpp, in sortCppIncludes, there is an explicit check for
"// clang-format off" but not the former version, when both should work.
Formatting is disabled as expected:
// clang-format off
#include "b.h"
#include "a.h"
Formatting re-orders headers when it shouldn't:
/* clang-format off */
#include "b.h"
#include "a.h" <- these will be sorted</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>