<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Replacements::add does not de-duplicate, as documented"
href="https://bugs.llvm.org/show_bug.cgi?id=38910">38910</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Replacements::add does not de-duplicate, as documented
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Windows NT
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>C++
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>steveire@gmail.com
</td>
</tr>
<tr>
<th>CC</th>
<td>dgregor@apple.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>The documentation contains:
/// 4. Replacement A(0, 3, "ab") and B(0, 3, "ab") are order-independent
since
/// applying the same replacement twice is equivalent to applying it once.
However, instead, the method duplicates the insertion.
This incorrect behavior is also tested:
TEST_F(ApplyAtomicChangesTest, AppliesDuplicateInsertions) {
setInput("int a;");
Changes.push_back(replacementToAtomicChange("key1", 5, 0, "b"));
Changes.push_back(replacementToAtomicChange("key2", 5, 0, "b"));
EXPECT_EQ("int abb;", rewrite());
}
When I run the modernize-use-override clang-tidy check with -export-fixes and
later apply them with clang-apply-replacements, this means that I get multiple
`override` keywords in the rewritten code.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>