<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Formatter/Cpp] Comments before conditions in if else statment are misalligned"
href="https://bugs.llvm.org/show_bug.cgi?id=38633">38633</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[Formatter/Cpp] Comments before conditions in if else statment are misalligned
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>jolesiak@google.com
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>I'm not sure whether current behavior is intended, but I think it could be
improved considering how common this pattern is:
Could be:
// description of the condition
if (true) {
x = 42;
// description of another condition
} else if (true) {
x = 42;
// description of else
} else {
x = 42;
}
Current formatting:
// description of the condition
if (true) {
x = 42;
// description of another condition
} else if (true) {
x = 42;
// description of else
} else {
x = 42;
}
One drawback, I can think of, of this change would be an incorrect indentation
in the following situation:
Base version:
if (...) {
x = 42;
// Assign 43 to x
x = 43;
} else if (...) {
}
Developer changed to:
if (...) {
x = 42;
// Assign 43 to x
// x = 43; - temporarily comment this line
} else if (...) {
}
After running clang-format on above code:
if (...) {
x = 42;
// Assign 43 to x
// x = 43; - temporarily comment this line
} else if (...) {
}
This would go back to the correct formatting after uncommenting the line, so I
don't think this should be an issue.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>