<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:richard-llvm@metafoo.co.uk" title="Richard Smith <richard-llvm@metafoo.co.uk>"> <span class="fn">Richard Smith</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - Regression(r313729): Invalid -Wunused-function warning"
href="https://bugs.llvm.org/show_bug.cgi?id=36584">bug 36584</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>INVALID
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>richard-llvm@metafoo.co.uk
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - Regression(r313729): Invalid -Wunused-function warning"
href="https://bugs.llvm.org/show_bug.cgi?id=36584#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - Regression(r313729): Invalid -Wunused-function warning"
href="https://bugs.llvm.org/show_bug.cgi?id=36584">bug 36584</a>
from <span class="vcard"><a class="email" href="mailto:richard-llvm@metafoo.co.uk" title="Richard Smith <richard-llvm@metafoo.co.uk>"> <span class="fn">Richard Smith</span></a>
</span></b>
<pre>The warning is correct.
The typedef does not establish a "typedef name for linkage" for the type
"Type", because it is a typedef for "const struct {...}", not a typedef for
"struct {...}". So the type Type has no linkage.
As a consequence, the function Function has no linkage. An identical
declaration in a different source file would declare a different function.
So, this matches the criteria we currently use for the -Wunused-function
warning: the function is local to this file, is not used nor marked
__attribute__((unused)), and its declaration does not have side-effects.
We previously got the linkage for `Function` wrong:
<a href="https://godbolt.org/g/4XaEri">https://godbolt.org/g/4XaEri</a>
Note that GCC and Clang 6 onwards agree that Function has internal linkage.
Clang <= 5 and EDG incorrectly give it external linkage.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>