<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - clang-format preprocessor indentation instability and trailing directive's off by one"
href="https://bugs.llvm.org/show_bug.cgi?id=36004">36004</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>clang-format preprocessor indentation instability and trailing directive's off by one
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>6.0
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>release blocker
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mzeren@vmware.com
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, krasimir@google.com, llvm-bugs@lists.llvm.org
</td>
</tr>
<tr>
<th>Blocks</th>
<td>35804
</td>
</tr></table>
<p>
<div>
<pre>r312125, which introduced preprocessor indentation, shipped with a known
issue where "indentation of comments immediately before indented
preprocessor lines is toggled on each run". There's a second issue where
trailing directives may be indented incorrectly. Both issues have reviews out:
<a href="https://reviews.llvm.org/D42036">https://reviews.llvm.org/D42036</a>
<a href="https://reviews.llvm.org/D42035">https://reviews.llvm.org/D42035</a>
I would prefer to do _something_ for the 6.0 release. Some options include:
a) review and submit the patches above to trunk and then and merge to the
release branch.
b) revert the feature for 6.0, keeping it on trunk.
c) document the known issues / mark the feature as experimental.</pre>
</div>
</p>
<div id="referenced">
<hr style="border: 1px dashed #969696">
<b>Referenced Bugs:</b>
<ul>
<li>
[<a class="bz_bug_link
bz_status_NEW "
title="NEW - [meta] 6.0.0 Release Blockers"
href="https://bugs.llvm.org/show_bug.cgi?id=35804">Bug 35804</a>] [meta] 6.0.0 Release Blockers
</li>
</ul>
</div>
<br>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>