<html>
    <head>
      <base href="https://bugs.llvm.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Please revert incomplete commit r306483 from 5.0.0 release branch (breaking clang binding tests)"
   href="https://bugs.llvm.org/show_bug.cgi?id=34386">34386</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Please revert incomplete commit r306483 from 5.0.0 release branch (breaking clang binding tests)
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>clang
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>trunk
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>-New Bugs
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedclangbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>mgorny@gentoo.org
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvm-bugs@lists.llvm.org
          </td>
        </tr>

        <tr>
          <th>Blocks</th>
          <td>33849
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Please revert the following commit from the 5.0 release branch:

commit 34efc84dff3e2cb91e6afdf460a7893a4a886029
Author: Jonathan Coe <<a href="mailto:jbcoe@me.com">jbcoe@me.com</a>>
Date:   Wed Jun 28 00:54:56 2017

    [libclang] Support for querying the exception specification type through
libclang

    Summary: This patch exposes the exception specification type (noexcept,
    etc.) of a C++ function through libclang and Python clang.cindex.

    Reviewers: rsmith, aaron.ballman

    Reviewed By: aaron.ballman

    Subscribers: jbcoe, cfe-commits

    Differential Revision: <a href="https://reviews.llvm.org/D34091">https://reviews.llvm.org/D34091</a>

    Patch by Andrew Bennieston

    git-svn-id: <a href="https://llvm.org/svn/llvm-project/cfe/trunk@306483">https://llvm.org/svn/llvm-project/cfe/trunk@306483</a>
91177308-0d34-0410-b5e6-96231b3b80d8


The committed change references an utility module that's missing (it hasn't
been committed with the change or included in the differential revision). I've
left a comment on D34091 over a month ago and received no reply.

This incomplete commit causes a test suite failure:

Failure: ImportError (No module named 'tests.util') ... ERROR

======================================================================
ERROR: Failure: ImportError (No module named 'tests.util')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.5/site-packages/nose/failure.py", line 39, in
runTest
    raise self.exc_val.with_traceback(self.tb)
  File "/usr/lib64/python3.5/site-packages/nose/loader.py", line 419, in
loadTestsFromName
    addr.filename, addr.module)
  File "/usr/lib64/python3.5/site-packages/nose/importer.py", line 47, in
importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/lib64/python3.5/site-packages/nose/importer.py", line 94, in
importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/usr/lib64/python3.5/imp.py", line 234, in load_module
    return load_source(name, filename, file)
  File "/usr/lib64/python3.5/imp.py", line 172, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 693, in _load
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 673, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File
"/usr/src/llvm/tools/clang/bindings/python/tests/test_exception_specification_kind.py",
line 3, in <module>
    from .util import get_tu
ImportError: No module named 'tests.util'

----------------------------------------------------------------------
Ran 111 tests in 2.182s

FAILED (errors=1)</pre>
        </div>
      </p>

        <div id="referenced">
          <hr style="border: 1px dashed #969696">
          <b>Referenced Bugs:</b>
          <ul>
              <li>
                [<a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [meta] 5.0.0 Release Blockers"
   href="https://bugs.llvm.org/show_bug.cgi?id=33849">Bug 33849</a>] [meta] 5.0.0 Release Blockers
              </li>
          </ul>
        </div>
        <br>

      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>