<html>
    <head>
      <base href="https://bugs.llvm.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - -fmodules crashes CodeGenModule::getMangledName(), called recursively"
   href="https://bugs.llvm.org/show_bug.cgi?id=33810">33810</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>-fmodules crashes CodeGenModule::getMangledName(), called recursively
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>clang
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>trunk
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>-New Bugs
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedclangbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>geek4civic@gmail.com
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvm-bugs@lists.llvm.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre><a href="http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/7503">http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/7503</a>
<a href="http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux">http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux</a>

r308041 (and r308040) began crashing.

As far as I investigated, lazily-resolved decls would call
CodeGenModule::getMangledName() recursively, but it is not re-entrant.

  StringRef &FoundStr = MangledDeclNames[CanonicalGD];
  if (!FoundStr.empty())
    return FoundStr;
...
  return FoundStr = Result.first->first();

When (MapVector)MangledDeclName grew (realloc), &FoundStr might not point valid
element, to cause memory corruption.

I think;
  return MangledDeclNames[CanonicalGD] = Result.first->first();
would work, but I'm not sure it'd be the right resolution.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>