<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - clang-format resets comment indentation before ifdefs"
href="https://bugs.llvm.org/show_bug.cgi?id=33130">33130</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>clang-format resets comment indentation before ifdefs
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>4.0
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>clemensgru@gmail.com
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>Hi,
when running clang-format over a large in-house C source base, I noticed that
it resets the indentation of comments before ifdefs to 0, although an empty
line was placed between comment and #ifdef.
(I understand that it resets the indentation to 0 if the comment is directly
before the ifdef, because then, we can assume that the comment belongs to the
ifdef)
But if there is an empty line in between, I think the comment should instead
follow the indentation from the code before the ifdef or (if unsure),
clang-format should just keep it as it was. (?)
Example:
It changes:
void f(void)
{
char c;
/* Comment */
#ifdef FOO
...
Into:
void f(void)
{
char c;
/* Comment */
#ifdef FOO
...
I am using clang-format 4.0.0 but I don't think this ever worked (tried many
versions in the past few years).
Thanks,
Clemens</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>