<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - clang-format breaks array initializer in unexpected places"
href="https://bugs.llvm.org/show_bug.cgi?id=32969">32969</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>clang-format breaks array initializer in unexpected places
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>lukasza@chromium.org
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>Given the following (manually formatted) snippet...
bool IsBlacklistedInstanceMethodName(llvm::StringRef name) {
static const char* kBlacklistedNames[] = {
// We should avoid renaming the method names listed below, because
// 1. They are used in templated code (e.g. in <algorithms>)
// 2. They (begin+end) are used in range-based for syntax sugar
// - for (auto x : foo) { ... } // <- foo.begin() will be called.
"begin", "end", "rbegin", "rend", "lock", "unlock", "try_lock",
// <a href="https://crbug.com/672902">https://crbug.com/672902</a>: Should not rewrite names that mimick methods
// from std library.
"at", "back", "clear" "empty", "erase", "find", "front", "insert",
"length", "size", "swap",
};
for (const auto& b : kBlacklistedNames) {
if (name == b)
return true;
}
return false;
}
clang-format reformats it to:
bool IsBlacklistedInstanceMethodName(llvm::StringRef name) {
static const char* kBlacklistedNames[] = {
// We should avoid renaming the method names listed below, because
// 1. They are used in templated code (e.g. in <algorithms>)
// 2. They (begin+end) are used in range-based for syntax sugar
// - for (auto x : foo) { ... } // <- foo.begin() will be called.
"begin", "end", "rbegin", "rend", "lock", "unlock", "try_lock",
// <a href="https://crbug.com/672902">https://crbug.com/672902</a>: Should not rewrite names that mimick methods
// from std library.
"at", "back",
"clear"
"empty",
"erase", "find", "front", "insert", "length", "size", "swap",
};
for (const auto& b : kBlacklistedNames) {
if (name == b)
return true;
}
return false;
}
I am rather surprised that 1) any reformatting is needed at all, 2) that
results take more lines than the original formatting, 3) that the line breaks
seem randomly placed (e.g. *why* after "back", and "clear" and "empty", but not
after "at" or "erase").</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>