<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - marked override but does not override should note similar functions"
href="https://bugs.llvm.org/show_bug.cgi?id=32647">32647</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>marked override but does not override should note similar functions
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>C++
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>nlewycky@google.com
</td>
</tr>
<tr>
<th>CC</th>
<td>dgregor@apple.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>We should look for similar functions in the base and list them when override is
used and it does not override. Since that is an error, when there's only one
best option we should also consider fixit hint + recovery with the fix.
Testcase:
struct Base {
virtual ~Base();
virtual void MixedConst() const {}
virtual void SlightTypo() {}
};
struct Derived : public Base {
virtual ~Derived();
virtual void MixedConst() override {}
virtual void SlightTypoe() override {}
};
$ clang++ -std=c++11 b10446365.cc
b10446365.cc:9:16: error: 'MixedConst' marked 'override' but does not override
any member functions
virtual void MixedConst() override {}
^
b10446365.cc:10:16: error: 'SlightTypoe' marked 'override' but does not
override
any member functions
virtual void SlightTypoe() override {}
^
2 errors generated.
The first one should note the difference in cv-qualifier, and also apply to
ref-qualifiers. The second one is an example where typo correction could pick
the right name out of the base.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>