<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:hans@chromium.org" title="Hans Wennborg <hans@chromium.org>"> <span class="fn">Hans Wennborg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - x86: inefficient code for x == 0 || x == 1"
href="https://bugs.llvm.org/show_bug.cgi?id=32524">bug 32524</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - x86: inefficient code for x == 0 || x == 1"
href="https://bugs.llvm.org/show_bug.cgi?id=32524#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - x86: inefficient code for x == 0 || x == 1"
href="https://bugs.llvm.org/show_bug.cgi?id=32524">bug 32524</a>
from <span class="vcard"><a class="email" href="mailto:hans@chromium.org" title="Hans Wennborg <hans@chromium.org>"> <span class="fn">Hans Wennborg</span></a>
</span></b>
<pre>(In reply to Sanjay Patel from <a href="show_bug.cgi?id=32524#c8">comment #8</a>)
<span class="quote">> After:
> <a href="https://reviews.llvm.org/rL299851">https://reviews.llvm.org/rL299851</a>
> ...we have:
>
> __Z1fi:
> 0000000000000000 cmpl $0x2, %edi
> 0000000000000003 setb %al
> 0000000000000006 retq
> __Z1hi:
> 0000000000000007 incl %edi
> 0000000000000009 cmpl $0x2, %edi
> 000000000000000c setb %al
> 000000000000000f retq
>
> So 7 bytes and 9 bytes.
>
> Hans, do you prefer to leave this bug open to track the -Os problem or open
> a new bug? We can still see the bug using an IR test case, but it should not
> repro from C source now. I suspect it is the same or related to <a class="bz_bug_link
bz_status_NEW "
title="NEW - [x86] optimizing for size results in bigger code because of repeated constant"
href="show_bug.cgi?id=27202">bug 27202</a>.</span >
Sorry for the slow reply.
Maybe just a comment on 27202 will suffice.
I'll close this one.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>