<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:zturner@google.com" title="Zachary Turner <zturner@google.com>"> <span class="fn">Zachary Turner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - PVS-Studio: Use of Uninitialized Variable (CWE-457)"
href="https://bugs.llvm.org/show_bug.cgi?id=32249">bug 32249</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - PVS-Studio: Use of Uninitialized Variable (CWE-457)"
href="https://bugs.llvm.org/show_bug.cgi?id=32249#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - PVS-Studio: Use of Uninitialized Variable (CWE-457)"
href="https://bugs.llvm.org/show_bug.cgi?id=32249">bug 32249</a>
from <span class="vcard"><a class="email" href="mailto:zturner@google.com" title="Zachary Turner <zturner@google.com>"> <span class="fn">Zachary Turner</span></a>
</span></b>
<pre>The patch looks fine, but I think I can make it a bit more concise. We should
be able to replace this entire else block with just
StringRef N(Name);
N = N.take_front(BytesLeft-1);
error(IO.mapStringZ(N));
I looked into why this wasn't caught by msan, and it's because this is a
hard-to-encounter edge case that doesn't have test coverage. I've been
improving the testability of this code for a while now, so we should be at the
point fairly soon where I can get test coverage for these weird edge cases.
I'm going to close this as fixed and submit the patch shortly. Thanks
Svyatoslav!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>