<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - merge and split include categories"
href="https://bugs.llvm.org/show_bug.cgi?id=32271">32271</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>merge and split include categories
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>daniel.pfeifer@mailbox.org
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=18092" name="attach_18092" title="Possible implementation">attachment 18092</a> <a href="attachment.cgi?id=18092&action=edit" title="Possible implementation">[details]</a></span>
Possible implementation
Currently, the #include directives in each block of includes are sorted by
category and then alphabetically. However, it is very common to have a block
of includes per category. Eg first the associated header, an empty line, then
all standard headers, another empty line, then all custom headers. If a
standard header is appended to the block of custom headers, clang-format will
keep it in that block.
Here is a question about that:
<a href="https://stackoverflow.com/questions/36687598/clang-format-groups-and-empty-lines">https://stackoverflow.com/questions/36687598/clang-format-groups-and-empty-lines</a>
The "fix" is simple: When collecting the includes, ignore empty lines. When
writing the sorted list of includes, insert an empty line after each category.
I cannot decide, whether that should be the default behavior or whether this
should be enabled by some config option. Please see the attached patch for a
possible implementation.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>