<html>
<head>
<base href="https://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - clang-format confused by initializer lists with embedded preprocessor directives"
href="https://llvm.org/bugs/show_bug.cgi?id=31427">31427</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>clang-format confused by initializer lists with embedded preprocessor directives
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dcheng@google.com
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>Here's the code before formatting:
std::vector<content::ContentBrowserClient::ServiceManifestInfo>
ChromeContentBrowserClient::GetExtraServiceManifests() {
return std::vector<content::ContentBrowserClient::ServiceManifestInfo>({
#if !defined(DISABLE_NACL)
{nacl::kNaClLoaderServiceName, IDR_NACL_LOADER_MANIFEST},
#if defined(OS_WIN)
{nacl::kNaClBrokerServiceName, IDR_NACL_BROKER_MANIFEST},
#endif // defined(OS_WIN)
#endif // !defined(DISABLE_NACL)
});
}
Here's the code after formatting:
std::vector<content::ContentBrowserClient::ServiceManifestInfo>
ChromeContentBrowserClient::GetExtraServiceManifests() {
return std::vector<content::ContentBrowserClient::ServiceManifestInfo>({
#if !defined(DISABLE_NACL)
{nacl::kNaClLoaderServiceName, IDR_NACL_LOADER_MANIFEST},
#if defined(OS_WIN)
{nacl::kNaClBrokerServiceName, IDR_NACL_BROKER_MANIFEST},
#endif // defined(OS_WIN)
#endif // !defined(DISABLE_NACL)
});
}
Here's how it ought to look:
std::vector<content::ContentBrowserClient::ServiceManifestInfo>
ChromeContentBrowserClient::GetExtraServiceManifests() {
return std::vector<content::ContentBrowserClient::ServiceManifestInfo>({
#if !defined(DISABLE_NACL)
{nacl::kNaClLoaderServiceName, IDR_NACL_LOADER_MANIFEST},
#if defined(OS_WIN)
{nacl::kNaClBrokerServiceName, IDR_NACL_BROKER_MANIFEST},
#endif // defined(OS_WIN)
#endif // !defined(DISABLE_NACL)
});
}
Code review link for full files/context:
<a href="https://codereview.chromium.org/2501913002/diff/320001/chrome/browser/chrome_content_browser_client.cc">https://codereview.chromium.org/2501913002/diff/320001/chrome/browser/chrome_content_browser_client.cc</a>
Reported in <a href="https://bugs.chromium.org/p/chromium/issues/detail?id=675554">https://bugs.chromium.org/p/chromium/issues/detail?id=675554</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>