<html>
<head>
<base href="https://llvm.org/bugs/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mkuper@google.com" title="Michael Kuperstein <mkuper@google.com>"> <span class="fn">Michael Kuperstein</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - SimplifyCFG blocks SROA optimization"
href="https://llvm.org/bugs/show_bug.cgi?id=30188">bug 30188</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>REOPENED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>FIXED
</td>
<td>---
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - SimplifyCFG blocks SROA optimization"
href="https://llvm.org/bugs/show_bug.cgi?id=30188#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - SimplifyCFG blocks SROA optimization"
href="https://llvm.org/bugs/show_bug.cgi?id=30188">bug 30188</a>
from <span class="vcard"><a class="email" href="mailto:mkuper@google.com" title="Michael Kuperstein <mkuper@google.com>"> <span class="fn">Michael Kuperstein</span></a>
</span></b>
<pre>Thanks for the quick fix, James!
I apologize if my own remarks came off as targeting you personally - I
certainly didn't mean that. I also didn't mean that I expect an insta-revert in
such cases. All I meant was that we can't brush off performance regressions
because a commit exposed existing behavior, as opposed to actively causing the
regressions.
Back to the technical issue at hand - at least for BinarySearch you meant
r280219, not r280217, right? In any case, it seems like you've had to revert
that. Reopening the bug for now.
As a side note - (b) was exactly what I meant by bailing out of
canSinkLastInstruction early. But if this ends up becoming the permanent
solution (as opposed to fixing it properly in SROA), I'm not sure it's enough
to bail only on a store to alloca - we'll have the same problem with a GEP
relative to an alloca, etc. So this should probably use getUnderlyingObject, or
something similar.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>