<html>
<head>
<base href="https://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [x86] unnecessary mov of constant function parameter"
href="https://llvm.org/bugs/show_bug.cgi?id=28957">28957</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[x86] unnecessary mov of constant function parameter
</td>
</tr>
<tr>
<th>Product</th>
<td>libraries
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Backend: X86
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>spatel+llvm@rotateright.com
</td>
</tr>
<tr>
<th>CC</th>
<td>llvm-bugs@lists.llvm.org
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>I'm not sure which layer should handle this, but I'm assuming it's something
late in the backend:
extern int bar(int);
int foo(int x) {
if (x == 1)
return bar(1); // 1st parameter is already '1'
else
return bar(-1);
}
or as IR:
define i32 @foo(i32 %x) {
entry:
%cmp = icmp eq i32 %x, 1
br i1 %cmp, label %if.then, label %if.else
if.then:
%call = tail call i32 @bar(i32 1) #2
br label %return
if.else:
%call1 = tail call i32 @bar(i32 -1) #2
br label %return
return:
%retval.0 = phi i32 [ %call, %if.then ], [ %call1, %if.else ]
ret i32 %retval.0
}
declare i32 @bar(i32)
---------------------------------------------------------------------------
$ ./clang -O2 -fomit-frame-pointer repeatParameter.c -S -o -
...
cmpl $1, %edi
jne LBB0_2
## BB#1:
movl $1, %edi <--- %edi is already '1'
jmp _bar <--- 2nd bug? MachineCSE?
LBB0_2:
movl $-1, %edi
jmp _bar
gcc gets this right:
foo(int):
cmpl $1, %edi
je .L3
movl $-1, %edi
.L3:
jmp bar(int)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>