<html>
<head>
<base href="https://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - clang-format should insert braces for conditionals with a multi-line body"
href="https://llvm.org/bugs/show_bug.cgi?id=26215">26215</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>clang-format should insert braces for conditionals with a multi-line body
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dcheng@google.com
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>From <a href="http://google.github.io/styleguide/cppguide.html#Conditionals">http://google.github.io/styleguide/cppguide.html#Conditionals</a>:
"In general, curly braces are not required for single-line statements, but they
are allowed if you like them; conditional or loop statements with complex
conditions or statements may be more readable with curly braces. Some projects
require that an if must always always have an accompanying brace."
The implication here seems to be that any conditional with a multi-line body
should use braces.
Right now, clang-format won't make any formatting changes to this snippet:
if (some_condition)
some_very_long_variable_name =
SomeVeryLongFunctionName(some_very_long_parameter_name);
But I believe that the style guide implies that properly formatted code should
look like this:
if (some_condition) {
some_very_long_variable_name =
SomeVeryLongFunctionName(some_very_long_parameter_name);
}</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>