<html>
<head>
<base href="https://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Kaleidoscope Tutorial Ch2 falsely claims that it doesn't depend on LLVM"
href="https://llvm.org/bugs/show_bug.cgi?id=25371">25371</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Kaleidoscope Tutorial Ch2 falsely claims that it doesn't depend on LLVM
</td>
</tr>
<tr>
<th>Product</th>
<td>Documentation
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>General docs
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>modocache@gmail.com
</td>
</tr>
<tr>
<th>CC</th>
<td>llvm-bugs@lists.llvm.org
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>The documentation in `docs/tutorial/LangImpl2.rst` states of the example code:
"Note that it is fully self-contained: you don’t need LLVM or any external
libraries at all for this." It proceeds to claim the example code can be
compiled with `clang++ -g -O3 toy.cpp`, which is not true.
The problem is that the example code imports `llvm/ADT/STLExtras.h` and uses
`llvm::make_unique`.
Two possible solutions:
1. Remove the claim and show a compile command that will actually work with the
LLVM import.
2. Remove references to `llvm::make_unique`, and actually have the code compile
with a simple `clang++ -g -O3 toy.cpp`.
I think #2 is the way to go, since readers new to LLVM won't immediately know
what `llvm::make_unique` does anyway--best to stick to stdlib.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>