<html>
<head>
<base href="https://llvm.org/bugs/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:richard-llvm@metafoo.co.uk" title="Richard Smith <richard-llvm@metafoo.co.uk>"> <span class="fn">Richard Smith</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - fixits need to be de-duped somehow"
href="https://llvm.org/bugs/show_bug.cgi?id=7417">bug 7417</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>REOPENED
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>richard-llvm@metafoo.co.uk
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>FIXED
</td>
<td>---
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - fixits need to be de-duped somehow"
href="https://llvm.org/bugs/show_bug.cgi?id=7417#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - fixits need to be de-duped somehow"
href="https://llvm.org/bugs/show_bug.cgi?id=7417">bug 7417</a>
from <span class="vcard"><a class="email" href="mailto:richard-llvm@metafoo.co.uk" title="Richard Smith <richard-llvm@metafoo.co.uk>"> <span class="fn">Richard Smith</span></a>
</span></b>
<pre>Fixits should be deduplicated, but this patch is not an appropriate direction
for doing so. If we want to support fixits in templates, we should have a
centralized mechanism for deduplication rather than working around this in an
ad-hoc, per-fixit way.
Also, this approach of modifying the template during instantiation is unsound
(it doesn't work if the AST node is reused in instantiations of the template,
the change doesn't get propagated into a module file built from the
compilation, it does the wrong thing if the same AST node is used in multiple
places, we modified the AST even in non-error cases such as SFINAE or the MS
extension path, ...).
Reverted in r249342. If we want to do this, we should use a centralized
mechanism that deduplicates identical fixits (and maybe even identical
diagnostics in general) from different instantiations of the same template, or
similar.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>