<html>
<head>
<base href="https://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Formatter needs more than 1 iteration to arrive at a fixed point"
href="https://llvm.org/bugs/show_bug.cgi?id=24385">24385</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Formatter needs more than 1 iteration to arrive at a fixed point
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Formatter
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>nicolasweber@gmx.de
</td>
</tr>
<tr>
<th>CC</th>
<td>djasper@google.com, klimek@google.com, llvm-bugs@lists.llvm.org
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>Consider:
class A {
// void ParsePopupMenuObj(APP_MENUITEM *
//ppMenuItem,JSObject * pObj);
// void DeleteMenuItems(APP_MENUITEM_ARRAY *
//pMenuItems);
// void AddMenuItem(APP_MENUITEM_ARRAY *
pMenuItems, HMENU
// hMenu, MENUITEMINFO MenuItemInfo);
};
If I format this repeatedly, I get (in sequence):
class A {
// void ParsePopupMenuObj(APP_MENUITEM
//*
// ppMenuItem,JSObject * pObj);
// void DeleteMenuItems(APP_MENUITEM_ARRAY
//*
// pMenuItems);
// void AddMenuItem(APP_MENUITEM_ARRAY *
pMenuItems,
// HMENU
// hMenu, MENUITEMINFO MenuItemInfo);
};
class A {
// void
//ParsePopupMenuObj(APP_MENUITEM
//*
// ppMenuItem,JSObject * pObj);
// void
//DeleteMenuItems(APP_MENUITEM_ARRAY
//*
// pMenuItems);
// void AddMenuItem(APP_MENUITEM_ARRAY *
// pMenuItems,
// HMENU
// hMenu, MENUITEMINFO MenuItemInfo);
};
class A {
// void
// ParsePopupMenuObj(APP_MENUITEM
//*
// ppMenuItem,JSObject * pObj);
// void
// DeleteMenuItems(APP_MENUITEM_ARRAY
//*
// pMenuItems);
// void AddMenuItem(APP_MENUITEM_ARRAY
// *
// pMenuItems,
// HMENU
// hMenu, MENUITEMINFO MenuItemInfo);
};
class A {
// void
// ParsePopupMenuObj(APP_MENUITEM
//*
// ppMenuItem,JSObject * pObj);
// void
// DeleteMenuItems(APP_MENUITEM_ARRAY
//*
// pMenuItems);
// void
// AddMenuItem(APP_MENUITEM_ARRAY
// *
// pMenuItems,
// HMENU
// hMenu, MENUITEMINFO MenuItemInfo);
};
This is a bit annoying: We have a presubmit that checks that new code is
clang-formatted by formatting the new lines and comparing it to the existing
code. If it's not equal, the tool suggests to run `git cl format`. Due to this
bug, the tool suggests doing that several times, until things finally settle
down.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>