<html>
    <head>
      <base href="https://llvm.org/bugs/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW " title="NEW --- - Kaleidoscope tutorial Chapter 4 code does not compile" href="https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_show-5Fbug.cgi-3Fid-3D24082&d=AwMBaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=pF93YEPyB-J_PERP4DUZOJDzFVX5ZQ57vQk33wu0vio&m=9K0If0Lq2TesHQ6usZ83Zb7Lr8dEVz89Y4blv50S8b8&s=zOS7zkykSPTH3chbnv1qZ4SMYnsKy30QhTD5kZAjs28&e=">24082</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Kaleidoscope tutorial Chapter 4 code does not compile
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Documentation
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>trunk
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>General docs
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>fredrik.ronquist@nrm.se
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvmbugs@cs.uiuc.edu
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=14573" name="attach_14573" title="Corrected Chapter 4 code.">attachment 14573</a> <a href="attachment.cgi?id=14573&action=edit" title="Corrected Chapter 4 code.">[details]</a></span>
Corrected Chapter 4 code.

The Kaleidoscope Chapter 4 code appears to be wrong. It does not compile in its
present form and it contains a section of code that is not present in later
chapters, with an ominous "FIX ME" comment inserted at the top.

The problem applies to both the toy.cpp file in
llvm/examples/Kaleidoscope/Chapter4/ and the corresponding code listing on the
documentation web site.

It seems like this is legacy code that has been fixed in Chapter 5 and later
chapters but not yet in Chapter 4. I attach a new version of the Chapter 4 code
that I fixed by deleting the erroneous code and instead inserting code from
Chapter 5 related to the content in Chapter 4. The attached Chapter 4 code
compiles and runs. It seems to do the right thing but I have not tested it
extensively and I am new to LLVM so someone more familiar with the LLVM
infrastructure should check it before it is committed.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>