<html>
<head>
<base href="http://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - MemoryBuffer could probably use mmap, even when copying the buffer."
href="http://llvm.org/bugs/show_bug.cgi?id=19868">19868</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>MemoryBuffer could probably use mmap, even when copying the buffer.
</td>
</tr>
<tr>
<th>Product</th>
<td>libraries
</td>
</tr>
<tr>
<th>Version</th>
<td>trunk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Support Libraries
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>rafael.espindola@gmail.com
</td>
</tr>
<tr>
<th>CC</th>
<td>llvmbugs@cs.uiuc.edu
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>Right now the logic is somewhat like
if (shouldUseMmap(...))
useMmap;
else
read loop
We could probably do
mmap the file
if (shouldUseMmap)
return a MemoryBuffer using the mmap.
else
memcopy and unmap the mapped file
This would have the advantage of avoiding the read loop and would also allow us
to pass the buffer to shoulduseMmmap which could then check if the last byte is
0 or not. That would let us gracefully fall back to copying the buffer on
broken file systems.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>