<html>
<head>
<base href="http://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - -Wconstant-logical-operand false positive when using "if (... || 0)" or "if (... || 1)""
href="http://llvm.org/bugs/show_bug.cgi?id=19125">19125</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>-Wconstant-logical-operand false positive when using "if (... || 0)" or "if (... || 1)"
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>C++
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>timurrrr@google.com
</td>
</tr>
<tr>
<th>CC</th>
<td>dgregor@apple.com, llvmbugs@cs.uiuc.edu
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>lib/asan/asan_poisoning.h:
46 if (value ||
47 SANITIZER_WINDOWS ||
48 shadow_end - shadow_beg <
common_flags()->clear_shadow_mmap_threshold) {
where SANITIZER_WINDOWS is "# define SANITIZER_WINDOWS 0" on Linux
yields
<a href="http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/15156/steps/compile/logs/stdio">http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/15156/steps/compile/logs/stdio</a>
COMPILE: clang_linux/asan-i386/i386:
/home/llvmbb/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/projects/compiler-rt/lib/asan/asan_linux.cc
In file included from
/home/llvmbb/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/projects/compiler-rt/lib/asan/asan_globals.cc:17:
/home/llvmbb/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/projects/compiler-rt/lib/asan/asan_poisoning.h:46:13:
error: use of logical '||' with constant operand
[-Werror,-Wconstant-logical-operand]
if (value ||
^
/home/llvmbb/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/projects/compiler-rt/lib/asan/asan_poisoning.h:46:13:
note: use '|' for a bitwise operation
if (value ||
^~
|
I believe this is a false positive -Wconstant-logical-operand.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>