<html>
<head>
<base href="http://llvm.org/bugs/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:manjian2006@gmail.com" title="manjian <manjian2006@gmail.com>"> <span class="fn">manjian</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - ARMAsmParser fails to recognize .req directive alias name in capital letters"
href="http://llvm.org/bugs/show_bug.cgi?id=18833">bug 18833</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>REOPENED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>WORKSFORME
</td>
<td>---
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - ARMAsmParser fails to recognize .req directive alias name in capital letters"
href="http://llvm.org/bugs/show_bug.cgi?id=18833#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED --- - ARMAsmParser fails to recognize .req directive alias name in capital letters"
href="http://llvm.org/bugs/show_bug.cgi?id=18833">bug 18833</a>
from <span class="vcard"><a class="email" href="mailto:manjian2006@gmail.com" title="manjian <manjian2006@gmail.com>"> <span class="fn">manjian</span></a>
</span></b>
<pre>Right,the req directive is case insensitive according to your test.But my point
is
unreq directive will not working,here my test case:
cat 1.s
.thumb
_foo:
OBJECT .req r2
mov r4, OBJECT
mov r4, oBjEcT
.unreq OBJECT
_foo2:
OBJECT .req r5
mov r4, OBJECT
.unreq OBJECT
bin/clang -target arm-linux-androideabi -march=armv7-a -c 1.s
1.s:12:15: error: redefinition of 'object' does not match original.
OBJECT .req r5
And here is patch to this bug:
Index: lib/Target/ARM/AsmParser/ARMAsmParser.cpp
===================================================================
--- lib/Target/ARM/AsmParser/ARMAsmParser.cpp (revision 201500)
+++ lib/Target/ARM/AsmParser/ARMAsmParser.cpp (working copy)
@@ -8243,7 +8243,7 @@
Error(L, "unexpected input in .unreq directive.");
return false;
}
- RegisterReqs.erase(Parser.getTok().getIdentifier());
+ RegisterReqs.erase(Parser.getTok().getIdentifier().lower());
Parser.Lex(); // Eat the identifier.
return false;
}</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>