<html>
    <head>
      <base href="http://llvm.org/bugs/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - -Wshadow should ignore variables declared and shadowed in macros"
   href="http://llvm.org/bugs/show_bug.cgi?id=18712">18712</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>-Wshadow should ignore variables declared and shadowed in macros
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>clang
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>3.4
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>enhancement
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>-New Bugs
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedclangbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>htam@apple.com
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvmbugs@cs.uiuc.edu
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr></table>
      <p>
        <div>
        <pre>I get many false positives from -Wshadow for variables that are used by some
macros that are then nested into each other.  -Wshadow should ignore the case
where a variable is only used by a macro expansion.

$ cat foo.c
#include <stdio.h>

#define BAD_EXAMPLE(n)                         \
   {                                           \
       int __increment = 0;                    \
       while (__increment < n) {

#define WORSE                                  \
       }                                       \
       __increment += 1;                       \
   }

void foo(void) {
   BAD_EXAMPLE(100) {
       BAD_EXAMPLE(5) {
           puts("hi");
       } WORSE;
   } WORSE;
}

$ clang foo.c -c -o /dev/null -Wshadow
foo.c:15:9: warning: declaration shadows a local variable [-Wshadow]
       BAD_EXAMPLE(5) {
       ^
foo.c:5:13: note: expanded from macro 'BAD_EXAMPLE'
       int __increment = 0;                    \
           ^
foo.c:14:5: note: previous declaration is here
   BAD_EXAMPLE(100) {
   ^
foo.c:5:13: note: expanded from macro 'BAD_EXAMPLE'
       int __increment = 0;                    \
           ^
1 warning generated.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>