<html>
    <head>
      <base href="http://llvm.org/bugs/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:rikka@google.com" title="Kaelyn Takata <rikka@google.com>"> <span class="fn">Kaelyn Takata</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - bad typo correction on method call suggesting qualifier"
   href="http://llvm.org/bugs/show_bug.cgi?id=18608">bug 18608</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Status</td>
           <td>NEW
           </td>
           <td>RESOLVED
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>rikka@google.com
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Resolution</td>
           <td>---
           </td>
           <td>FIXED
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - bad typo correction on method call suggesting qualifier"
   href="http://llvm.org/bugs/show_bug.cgi?id=18608#c1">Comment # 1</a>
              on <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - bad typo correction on method call suggesting qualifier"
   href="http://llvm.org/bugs/show_bug.cgi?id=18608">bug 18608</a>
              from <span class="vcard"><a class="email" href="mailto:rikka@google.com" title="Kaelyn Takata <rikka@google.com>"> <span class="fn">Kaelyn Takata</span></a>
</span></b>
        <pre>Strictly speaking, the suggested correction was good, and it was simply using
the wrong source location for underlining and the fixit. Ironically, I had
fixed this problem in the case of too few arguments in r191450 but missed that
the case of too many arguments had the exact same problem (and the exact same
few lines of code around a call to TryTypoCorrectionForCall).

I've committed r200268 which applies the fix from r191450 to the
too-many-arguments case, and also fixes the underlining for both cases (which
r191450 had overlooked).</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>