<html>
<head>
<base href="http://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Consider warning on unintentional uses of the comma operator"
href="http://llvm.org/bugs/show_bug.cgi?id=18116">18116</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Consider warning on unintentional uses of the comma operator
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>C++
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>nicolasweber@gmx.de
</td>
</tr>
<tr>
<th>CC</th>
<td>dgregor@apple.com, llvmbugs@cs.uiuc.edu
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=11647" name="attach_11647" title="prototype patch">attachment 11647</a> <a href="attachment.cgi?id=11647&action=edit" title="prototype patch">[details]</a></span>
prototype patch
In v8, some code called
v8::Debug::SetLiveEditEnabled(false), env->GetIsolate();
when it meant to call
v8::Debug::SetLiveEditEnabled(false, env->GetIsolate());
(SetLiveEditEnabled() has a default parameter for the 2nd argument)
A possible warning would be to check if the lhs of a comma operator is a call
and the call is still valid when adding the rhs to the call arguments. The
attached patch implements this idea – but it doesn't catch the same thing for
overloads, and it didn't find any other bugs in chromium, so I'm not sure if
it's worth it. I'm attaching the patch if someone else wants to do something
with it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>