<html>
    <head>
      <base href="http://llvm.org/bugs/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - ARM backend incorrectly lowers COPY_STRUCT_BYVAL_I32 for thumb1 targets"
   href="http://llvm.org/bugs/show_bug.cgi?id=17309">17309</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>ARM backend incorrectly lowers COPY_STRUCT_BYVAL_I32 for thumb1 targets
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>tools
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>trunk
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Windows NT
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>llc
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>dpeixott@codeaurora.org
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvmbugs@cs.uiuc.edu
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=11248" name="attach_11248" title="thumb1-byval.ll">attachment 11248</a> <a href="attachment.cgi?id=11248&action=edit" title="thumb1-byval.ll">[details]</a></span>
thumb1-byval.ll

Summary
--------
The lowering of COPY_STRUCT_BYVAL_I32 generates the post-increment forms of
ldr/ldrh/ldrb instructions. Thumb1 does not have the post-increment form of
these instructions. If I pass the generated assembly to gcc it will complain
with an error like this:

  Error: cannot honor width suffix -- `ldrb r3,[r0],#1'

The integrated assembler generates an object file with an invalid instruction
encoding.

Details
--------
The COPY_STRUCT_BYVAL_I32 instruction is used to pass structures as function
arguments by copying a structure from a source to a destination location while
respecting alignment. The instruction is a pseudo-instruction that is
implemented by custom lowering in ARMTargetLowering::EmitStructByval() at the
end of instruction selection. It looks like this function was not written to
correctly handle Thumb1 targets.

The struct is copied using LDRB_POST_IMM, LDRH_POST, and LDR_POST_IMM
instructions. These correspond to the the post-increment forms of the load
instructions. Thumb1 does not support these modes. See (for example) section
A8.8.79 of the arm manual for LDRH where only Thumb2 supports the
post-increment form (encoding T3).

I'm attaching a FileCheck-ified test case that exhibits the incorrect behavior.

To reproduce:

$ llc -mtriple thumbv5 < thumb1-byval.ll</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>