<html>
<head>
<base href="http://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - -Wlogical-not-parentheses doesn't suggest closing paren correctly in DCHECK() macro"
href="http://llvm.org/bugs/show_bug.cgi?id=16673">16673</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>-Wlogical-not-parentheses doesn't suggest closing paren correctly in DCHECK() macro
</td>
</tr>
<tr>
<th>Product</th>
<td>clang
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Frontend
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedclangbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>nicolasweber@gmx.de
</td>
</tr>
<tr>
<th>CC</th>
<td>llvmbugs@cs.uiuc.edu
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>../../chrome/browser/sync/glue/data_type_manager_impl.cc:447:10: error: logical
not is only applied to the left hand side of this comparison
[-Werror,-Wlogical-not-parentheses]
DCHECK(!result.status == OK ||
^ ~~
../../base/logging.h:735:55: note: expanded from macro 'DCHECK'
LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON() && !(condition)) \
^
../../base/logging.h:386:5: note: expanded from macro 'LAZY_STREAM'
!(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
^
../../chrome/browser/sync/glue/data_type_manager_impl.cc:447:10: note: add
parentheses after the '!' to evaluate the comparison first
DCHECK(!result.status == OK ||
^
(
../../base/logging.h:735:55: note: expanded from macro 'DCHECK'
LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON() && !(condition)) \
^
../../base/logging.h:386:5: note: expanded from macro 'LAZY_STREAM'
!(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
^
../../chrome/browser/sync/glue/data_type_manager_impl.cc:447:10: note: add
parentheses around left hand side expression to silence this warning
DCHECK(!result.status == OK ||
^
(
../../base/logging.h:735:55: note: expanded from macro 'DCHECK'
LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON() && !(condition)) \
^
../../base/logging.h:386:5: note: expanded from macro 'LAZY_STREAM'
!(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
^
1 error generated.
Note that the missing ')' in the fixit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>