[llvm-bugs] [Bug 39832] New: VScode extension always popups output panel on errors

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=39832

            Bug ID: 39832
           Summary: VScode extension always popups output panel on errors
           Product: clang-tools-extra
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: clangd
          Assignee: unassignedclangbugs at nondot.org
          Reporter: mail at 3v1n0.net
                CC: llvm-bugs at lists.llvm.org

The extension has `revealOutputChannelOn` set to true on Errors, but this is
quite annoying when doing normal development.

While the output should be always be visible in the output panel, the panel
should, optionally, not to popup.

To workaround this, I've to manually patch the generated js at each release
with something like this.

Having an option flag would be indeed more convenient.

--- a/node_modules/vscode-languageclient/lib/client.js  2018-11-28
14:39:26.250075271 -0500
+++ b/node_modules/vscode-languageclient/lib/client.js  2018-11-28
14:39:29.857825456 -0500
@@ -1623,7 +1623,7 @@
             synchronize: clientOptions.synchronize || {},
             diagnosticCollectionName: clientOptions.diagnosticCollectionName,
             outputChannelName: clientOptions.outputChannelName || this._name,
-            revealOutputChannelOn: clientOptions.revealOutputChannelOn ||
RevealOutputChannelOn.Error,
+            revealOutputChannelOn: clientOptions.revealOutputChannelOn ||
RevealOutputChannelOn.Never,
             stdioEncoding: clientOptions.stdioEncoding || 'utf8',
             initializationOptions: clientOptions.initializationOptions,
             initializationFailedHandler:
clientOptions.initializationFailedHandler,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20181128/64059b7d/attachment-0001.html>