[llvm-bugs] [Bug 37532] New: tests require FileCheck's deprecated overlapping CHECK-DAG
via llvm-bugs
llvm-bugs at lists.llvm.org
Sat May 19 11:55:24 PDT 2018
https://bugs.llvm.org/show_bug.cgi?id=37532
Bug ID: 37532
Summary: tests require FileCheck's deprecated overlapping
CHECK-DAG
Product: new-bugs
Version: trunk
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P
Component: new bugs
Assignee: unassignedbugs at nondot.org
Reporter: jdenny.ornl at gmail.com
CC: llvm-bugs at lists.llvm.org
The following patch changes FileCheck's CHECK-DAG directive not to permit
matches to overlap the matches of any preceding consecutive CHECK-DAG
directives:
https://reviews.llvm.org/D47106
However, that change breaks many existing tests, which are tracked by this
bugzilla issue.
That patch also implements the FileCheck command-line option
-allow-deprecated-dag-overlap, which reverts CHECK-DAG to the old overlapping
behavior. Before committing the above patch, we will add that option to the
broken tests. After committing, we will gradually adjust those tests for the
new behavior.
The list of unexpected test failures I'm seeing currently is below. You'll
notice I haven't yet cloned every LLVM repo, so there might be other unexpected
failures elsewhere.
Setup
-----
The repos and base commits I'm testing:
$ find . -name .git -exec sh -c 'cd {}/.. && echo r`git svn find-rev @` `git
rev-parse @` {}' \;
r332809 06b38392dd60537b5d5732362f0ea8ec8dcea3d5 ./.git
r332775 2dc250081581f8dca5807819fbf4fed217f87ab5 ./tools/polly/.git
r332789 8daca416e4060dc49314744d23766e267d3dd919 ./tools/lld/.git
r332806 6b2fbf833d28a7e73f5728593cf6f9ba95cc2c24 ./tools/clang/.git
r332792 da054b1bc17dd4b6607aa9c8d7e66ff4d77d1308 ./projects/compiler-rt/.git
r332797 262632877b2d25065267b8641c3a083204636905 ./projects/libcxx/.git
r332495 abedd0661b48ab4541cd7fbbf68de130798c4b16 ./projects/openmp/.git
r332660 b9d870b66613fe18698e504ad78f3c7a98cb4a32 ./projects/test-suite/.git
r332767 e0330b61d74b898ee64922d0a3d50c3562f6ddb1 ./projects/libcxxabi/.git
llvm.git also includes the non-overlapping CHECK-DAG patch as of the
following version:
<https://reviews.llvm.org/D47106?id=147664>
polly.git also includes the following patch to fix a break in the build:
diff --git a/lib/Support/RegisterPasses.cpp b/lib/Support/RegisterPasses.cpp
index 2ce0f63e..975ec574 100644
--- a/lib/Support/RegisterPasses.cpp
+++ b/lib/Support/RegisterPasses.cpp
@@ -706,7 +706,7 @@ void RegisterPollyPasses(PassBuilder &PB) {
} // namespace polly
// Plugin Entrypoint:
-extern "C" ::llvm::PassPluginLibraryInfo LLVM_ATTRIBUTE_WEAK
LLVM_PLUGIN_EXPORT
+extern "C" ::llvm::PassPluginLibraryInfo LLVM_ATTRIBUTE_WEAK
llvmGetPassPluginInfo() {
return {LLVM_PLUGIN_API_VERSION, "Polly", LLVM_VERSION_STRING,
polly::RegisterPollyPasses};
Results
-------
ninja check-all gives the following summary of unexpected failures, of
which 101 are new. I have added asterisks in front of all failures
that are also present without the CHECK-DAG patch.
Failing Tests (110):
Clang :: CodeGen/dso-local-executable.c
Clang :: CodeGen/may-alias.c
Clang :: CodeGenCUDA/convergent.cu
Clang :: CodeGenCUDA/device-stub.cu
Clang :: CodeGenCXX/debug-info-line-if.cpp
Clang :: CodeGenCXX/dllexport.cpp
Clang :: CodeGenCXX/inline-hint.cpp
Clang :: CodeGenCXX/linetable-eh.cpp
Clang :: CodeGenCXX/mangle-ms-cxx14.cpp
Clang :: CodeGenCXX/regcall.cpp
Clang :: CodeGenCXX/runtime-dllstorage.cpp
Clang :: CodeGenObjC/dllstorage.m
Clang :: Driver/cuda-no-pgo-or-coverage.cu
Clang :: OpenMP/for_codegen.cpp
Clang :: OpenMP/for_reduction_codegen.cpp
Clang :: OpenMP/for_reduction_codegen_UDR.cpp
Clang :: OpenMP/sections_reduction_codegen.cpp
Clang :: OpenMP/target_map_codegen.cpp
Clang :: OpenMP/target_parallel_codegen.cpp
Clang :: OpenMP/target_parallel_for_codegen.cpp
Clang :: OpenMP/target_parallel_for_simd_codegen.cpp
Clang :: OpenMP/target_simd_codegen.cpp
Clang :: OpenMP/target_teams_codegen.cpp
Clang :: OpenMP/target_teams_distribute_codegen.cpp
Clang :: OpenMP/target_teams_distribute_firstprivate_codegen.cpp
Clang :: OpenMP/target_teams_distribute_parallel_for_private_codegen.cpp
Clang ::
OpenMP/target_teams_distribute_parallel_for_simd_private_codegen.cpp
Clang :: OpenMP/target_teams_distribute_private_codegen.cpp
Clang :: OpenMP/target_teams_distribute_simd_codegen.cpp
Clang :: OpenMP/target_teams_distribute_simd_firstprivate_codegen.cpp
Clang :: OpenMP/target_teams_distribute_simd_private_codegen.cpp
Clang :: OpenMP/teams_distribute_firstprivate_codegen.cpp
Clang :: OpenMP/teams_distribute_parallel_for_private_codegen.cpp
Clang :: OpenMP/teams_distribute_parallel_for_simd_private_codegen.cpp
Clang :: OpenMP/teams_distribute_private_codegen.cpp
Clang :: OpenMP/teams_distribute_simd_firstprivate_codegen.cpp
Clang :: OpenMP/teams_distribute_simd_private_codegen.cpp
Clang :: Profile/c-captured.c
Clang :: Profile/c-general.c
Clang :: Profile/cxx-lambda.cpp
Clang :: SemaCXX/pragma-optimize.cpp
LLVM :: Bitcode/thinlto-function-summary-originalnames.ll
LLVM :: Bitcode/thinlto-summary-local-5.0.ll
LLVM :: Bitcode/upgrade-pointer-address-space.ll
LLVM :: CodeGen/AArch64/fp16-v8-instructions.ll
LLVM :: CodeGen/AArch64/swifterror.ll
LLVM :: CodeGen/AMDGPU/callee-special-input-sgprs.ll
LLVM :: CodeGen/AMDGPU/cvt_f32_ubyte.ll
LLVM :: CodeGen/AMDGPU/fceil64.ll
LLVM :: CodeGen/AMDGPU/fcmp.f16.ll
LLVM :: CodeGen/AMDGPU/fp_to_sint.ll
LLVM :: CodeGen/AMDGPU/fp_to_uint.ll
LLVM :: CodeGen/AMDGPU/fpext.f16.ll
LLVM :: CodeGen/AMDGPU/half.ll
LLVM :: CodeGen/AMDGPU/llvm.amdgcn.interp.ll
LLVM :: CodeGen/AMDGPU/llvm.exp2.ll
LLVM :: CodeGen/AMDGPU/llvm.log.ll
LLVM :: CodeGen/AMDGPU/llvm.log10.ll
LLVM :: CodeGen/AMDGPU/llvm.log2.ll
LLVM :: CodeGen/AMDGPU/load-constant-i32.ll
LLVM :: CodeGen/AMDGPU/load-constant-i8.ll
LLVM :: CodeGen/AMDGPU/load-global-i16.ll
LLVM :: CodeGen/AMDGPU/load-global-i32.ll
LLVM :: CodeGen/AMDGPU/load-global-i8.ll
LLVM :: CodeGen/AMDGPU/load-local-i16.ll
LLVM :: CodeGen/AMDGPU/load-local-i8.ll
LLVM :: CodeGen/AMDGPU/mul.ll
LLVM :: CodeGen/AMDGPU/private-element-size.ll
LLVM :: CodeGen/AMDGPU/setcc.ll
LLVM :: CodeGen/AMDGPU/shl.ll
LLVM :: CodeGen/AMDGPU/shl_add_constant.ll
LLVM :: CodeGen/AMDGPU/sign_extend.ll
LLVM :: CodeGen/AMDGPU/sra.ll
LLVM :: CodeGen/AMDGPU/srl.ll
LLVM :: CodeGen/AMDGPU/store-hi16.ll
LLVM :: CodeGen/AMDGPU/store-v3i64.ll
LLVM :: CodeGen/AMDGPU/udivrem.ll
LLVM :: CodeGen/AMDGPU/uint_to_fp.ll
LLVM :: CodeGen/AMDGPU/v_mac_f16.ll
LLVM :: CodeGen/ARM/fp16-promote.ll
LLVM :: CodeGen/Mips/bswap.ll
LLVM :: CodeGen/Mips/cconv/arguments-hard-float-varargs.ll
LLVM :: CodeGen/Mips/cconv/arguments-varargs.ll
LLVM :: CodeGen/Mips/cconv/callee-saved.ll
LLVM :: CodeGen/Mips/cconv/return-struct.ll
LLVM :: CodeGen/Mips/madd-msub.ll
LLVM :: CodeGen/Mips/msa/basic_operations.ll
LLVM :: CodeGen/Mips/no-odd-spreg.ll
LLVM :: CodeGen/NVPTX/f16x2-instructions.ll
LLVM :: CodeGen/NVPTX/intrinsic-old.ll
LLVM :: CodeGen/NVPTX/param-load-store.ll
LLVM :: CodeGen/PowerPC/build-vector-tests.ll
LLVM :: CodeGen/PowerPC/memcpy-vec.ll
LLVM :: CodeGen/PowerPC/swaps-le-1.ll
LLVM :: CodeGen/SystemZ/backchain.ll
LLVM :: CodeGen/SystemZ/cond-load-03.ll
LLVM :: CodeGen/X86/x86-cmov-converter.ll
LLVM :: Instrumentation/MemorySanitizer/msan_basic.ll
LLVM :: ThinLTO/X86/alias_import.ll
* LeakSanitizer-AddressSanitizer-x86_64 :: TestCases/Linux/use_tls_dynamic.cc
* LeakSanitizer-Standalone-x86_64 :: TestCases/Linux/use_tls_dynamic.cc
* MemorySanitizer-X86_64 :: dtls_test.c
* MemorySanitizer-lld-X86_64 :: dtls_test.c
Profile-x86_64 :: instrprof-visibility.cpp
* SanitizerCommon-asan-x86_64-Linux :: Linux/name_to_handle_at.cc
* SanitizerCommon-lsan-x86_64-Linux :: Linux/name_to_handle_at.cc
* SanitizerCommon-msan-x86_64-Linux :: Linux/name_to_handle_at.cc
* SanitizerCommon-tsan-x86_64-Linux :: Linux/name_to_handle_at.cc
* SanitizerCommon-ubsan-x86_64-Linux :: Linux/name_to_handle_at.cc
libomp :: ompt/parallel/not_enough_threads.c
Expected Passes : 48982
Expected Failures : 247
Unsupported Tests : 1745
Unexpected Failures: 110
--
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20180519/63299fd2/attachment-0001.html>
More information about the llvm-bugs
mailing list